chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm - Issue 1317443002: Fix UAF in Origin Info Bubble and permission settings UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm

Issue 1317443002: Fix UAF in Origin Info Bubble and permission settings UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another Andorid call site. Checked all call sites. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm ('k') | chrome/browser/ui/views/website_settings/website_settings_popup_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm

index 769218e07ed2872de52f954f845a68fd3c0c5adf..b254463e9d8152cd0c0f26781b22eadcd7f1a293 100644

--- a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm

@@ -149,7 +149,7 @@ class WebsiteSettingsBubbleControllerTest : public CocoaTest {

// Creates a new website settings bubble, with the given default width.

// If |default_width| is 0, the *default* default width will be used.

void CreateBubbleWithWidth(CGFloat default_width) {

- bridge_ = new WebsiteSettingsUIBridge();

+ bridge_ = new WebsiteSettingsUIBridge(nullptr);

// The controller cleans up after itself when the window closes.

controller_ = [WebsiteSettingsBubbleControllerForTesting alloc];