chrome/browser/ui/android/website_settings_popup_android.cc - Issue 1317443002: Fix UAF in Origin Info Bubble and permission settings UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/website_settings_popup_android.cc

Issue 1317443002: Fix UAF in Origin Info Bubble and permission settings UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another Andorid call site. Checked all call sites. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/connection_info_popup_android.cc ('k') | chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/website_settings_popup_android.cc

diff --git a/chrome/browser/ui/android/website_settings_popup_android.cc b/chrome/browser/ui/android/website_settings_popup_android.cc

index e698f03cc02df4dfba11781ca12779da5871f640..4b4c9f17ef7da55c1b59d95a18193ae9b137d29c 100644

--- a/chrome/browser/ui/android/website_settings_popup_android.cc

+++ b/chrome/browser/ui/android/website_settings_popup_android.cc

@@ -55,7 +55,7 @@ WebsiteSettingsPopupAndroid::WebsiteSettingsPopupAndroid(

this,

Profile::FromBrowserContext(web_contents->GetBrowserContext()),

TabSpecificContentSettings::FromWebContents(web_contents),

- InfoBarService::FromWebContents(web_contents),

+ web_contents,

nav_entry->GetURL(),

nav_entry->GetSSL(),

content::CertStore::GetInstance()));