Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Side by Side Diff: chrome/browser/ui/website_settings/website_settings.h

Issue 1317443002: Fix UAF in Origin Info Bubble and permission settings UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBSITE_SETTINGS_WEBSITE_SETTINGS_H_ 5 #ifndef CHROME_BROWSER_UI_WEBSITE_SETTINGS_WEBSITE_SETTINGS_H_
6 #define CHROME_BROWSER_UI_WEBSITE_SETTINGS_WEBSITE_SETTINGS_H_ 6 #define CHROME_BROWSER_UI_WEBSITE_SETTINGS_WEBSITE_SETTINGS_H_
7 7
8 #include "base/strings/string16.h" 8 #include "base/strings/string16.h"
9 #include "chrome/browser/content_settings/tab_specific_content_settings.h" 9 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
10 #include "components/content_settings/core/common/content_settings.h" 10 #include "components/content_settings/core/common/content_settings.h"
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 return site_identity_details_; 129 return site_identity_details_;
130 } 130 }
131 131
132 base::string16 organization_name() const { 132 base::string16 organization_name() const {
133 return organization_name_; 133 return organization_name_;
134 } 134 }
135 135
136 // SiteDataObserver implementation. 136 // SiteDataObserver implementation.
137 void OnSiteDataAccessed() override; 137 void OnSiteDataAccessed() override;
138 138
139 void DoNotShowInfoBar() { show_info_bar_ = false; }
felt 2015/08/25 18:20:08 nit: should this be a setter for show_info_bar_ in
140
139 private: 141 private:
140 // Initializes the |WebsiteSettings|. 142 // Initializes the |WebsiteSettings|.
141 void Init(Profile* profile, 143 void Init(Profile* profile,
142 const GURL& url, 144 const GURL& url,
143 const content::SSLStatus& ssl); 145 const content::SSLStatus& ssl);
144 146
145 // Sets (presents) the information about the site's permissions in the |ui_|. 147 // Sets (presents) the information about the site's permissions in the |ui_|.
146 void PresentSitePermissions(); 148 void PresentSitePermissions();
147 149
148 // Sets (presents) the information about the site's data in the |ui_|. 150 // Sets (presents) the information about the site's data in the |ui_|.
149 void PresentSiteData(); 151 void PresentSiteData();
150 152
151 // Sets (presents) the information about the site's identity and connection 153 // Sets (presents) the information about the site's identity and connection
152 // in the |ui_|. 154 // in the |ui_|.
153 void PresentSiteIdentity(); 155 void PresentSiteIdentity();
154 156
155 // The website settings UI displays information and controls for site 157 // The website settings UI displays information and controls for site-
156 // specific data (local stored objects like cookies), site specific 158 // specific data (local stored objects like cookies), site-specific
157 // permissions (location, popup, plugin, etc. permissions) and site specific 159 // permissions (location, pop-up, plugin, etc. permissions) and site-specific
158 // information (identity, connection status, etc.). 160 // information (identity, connection status, etc.).
159 WebsiteSettingsUI* ui_; 161 WebsiteSettingsUI* ui_;
160 162
161 // The infobar service of the active tab. 163 // The infobar service of the active tab.
162 InfoBarService* infobar_service_; 164 InfoBarService* infobar_service_;
163 165
164 // The flag that controls whether an infobar is displayed after the website 166 // The flag that controls whether an infobar is displayed after the website
165 // settings UI is closed or not. 167 // settings UI is closed or not.
166 bool show_info_bar_; 168 bool show_info_bar_;
167 169
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 // Service for managing SSL error page bypasses. Used to revoke bypass 224 // Service for managing SSL error page bypasses. Used to revoke bypass
223 // decisions by users. 225 // decisions by users.
224 ChromeSSLHostStateDelegate* chrome_ssl_host_state_delegate_; 226 ChromeSSLHostStateDelegate* chrome_ssl_host_state_delegate_;
225 227
226 bool did_revoke_user_ssl_decisions_; 228 bool did_revoke_user_ssl_decisions_;
227 229
228 DISALLOW_COPY_AND_ASSIGN(WebsiteSettings); 230 DISALLOW_COPY_AND_ASSIGN(WebsiteSettings);
229 }; 231 };
230 232
231 #endif // CHROME_BROWSER_UI_WEBSITE_SETTINGS_WEBSITE_SETTINGS_H_ 233 #endif // CHROME_BROWSER_UI_WEBSITE_SETTINGS_WEBSITE_SETTINGS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698