Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1290)

Unified Diff: chrome/browser/extensions/extension_service.h

Issue 131743021: app_shell: Extract extension runtime data from ExtensionService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase, RuntimeDataTest tweak, win warning Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_host.cc ('k') | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_service.h
diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h
index 14167eff09f30425d05aa5ed57e844f9ae18b524..2473216742e8bd98d4c2a705d7048f58c94c6ff2 100644
--- a/chrome/browser/extensions/extension_service.h
+++ b/chrome/browser/extensions/extension_service.h
@@ -187,28 +187,11 @@ class ExtensionService
const std::string& predecessor_extension_id,
const std::string& successor_extension_id);
- // Whether the persistent background page, if any, is ready. We don't load
- // other components until then. If there is no background page, or if it is
- // non-persistent (lazy), we consider it to be ready.
- bool IsBackgroundPageReady(const extensions::Extension* extension) const;
- void SetBackgroundPageReady(const extensions::Extension* extension);
-
- // Getter and setter for the flag that specifies whether the extension is
- // being upgraded.
- bool IsBeingUpgraded(const extensions::Extension* extension) const;
- void SetBeingUpgraded(const extensions::Extension* extension, bool value);
-
// Getter and setter for the flag that specifies whether the extension is
// being reloaded.
bool IsBeingReloaded(const std::string& extension_id) const;
void SetBeingReloaded(const std::string& extension_id, bool value);
- // Getter and setter for the flag that specifies if the extension has used
- // the webrequest API.
- // TODO(mpcomplete): remove. http://crbug.com/100411
- bool HasUsedWebRequest(const extensions::Extension* extension) const;
- void SetHasUsedWebRequest(const extensions::Extension* extension, bool value);
-
// Initialize and start all installed extensions.
void Init();
@@ -616,23 +599,6 @@ class ExtensionService
#endif
private:
- // Contains Extension data that can change during the life of the process,
- // but does not persist across restarts.
- struct ExtensionRuntimeData {
- // True if the background page is ready.
- bool background_page_ready;
-
- // True while the extension is being upgraded.
- bool being_upgraded;
-
- // True if the extension has used the webRequest API.
- bool has_used_webrequest;
-
- ExtensionRuntimeData();
- ~ExtensionRuntimeData();
- };
- typedef std::map<std::string, ExtensionRuntimeData> ExtensionRuntimeDataMap;
-
// Signals *ready_ and sends a notification to the listeners.
void SetReadyAndNotifyListeners();
@@ -741,9 +707,6 @@ class ExtensionService
// Hold the set of pending extensions.
extensions::PendingExtensionManager pending_extension_manager_;
- // The map of extension IDs to their runtime data.
- ExtensionRuntimeDataMap extension_runtime_data_;
-
// The full path to the directory where extensions are installed.
base::FilePath install_directory_;
« no previous file with comments | « chrome/browser/extensions/extension_host.cc ('k') | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698