app_shell: Extract extension runtime data from ExtensionService

chrome/browser/extensions/extension_host.cc

Index: chrome/browser/extensions/extension_host.cc
diff --git a/chrome/browser/extensions/extension_host.cc b/chrome/browser/extensions/extension_host.cc
index 8b5c6fe081e98bc35d4b4a64af4b81634f881b40..c731e18cd3c225f1d6db79f85b328bf90337a4c3 100644
--- a/chrome/browser/extensions/extension_host.cc
+++ b/chrome/browser/extensions/extension_host.cc
@@ -41,6 +41,7 @@
 #include "extensions/browser/extension_error.h"
 #include "extensions/browser/extensions_browser_client.h"
 #include "extensions/browser/process_manager.h"
+#include "extensions/browser/runtime_data.h"
 #include "extensions/browser/view_type_utils.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_urls.h"
@@ -323,9 +324,9 @@ void ExtensionHost::DocumentAvailableInMainFrame() {
 
 void ExtensionHost::OnDocumentAvailable() {
   DCHECK(extension_host_type_ == VIEW_TYPE_EXTENSION_BACKGROUND_PAGE);
-  ExtensionService* service = GetExtensionService();
-  if (service)
-    service->SetBackgroundPageReady(extension_);
+  ExtensionSystem::GetForBrowserContext(browser_context_)
+      ->runtime_data()
+      ->SetBackgroundPageReady(extension_, true);

[not at google - send to devlin, 2014/01/22 16:17:43]

(I would just put this on the same line as runtime_data() but whatever you
prefer)

[James Cook, 2014/01/22 17:41:52]

This is the output of clang-format, so I prefer it.

   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_EXTENSION_BACKGROUND_PAGE_READY,
       content::Source<const Extension>(extension_),