Add a function for determining if official Google Chrome API key is used.

Add a function for determining if official Google Chrome API key is used.

I'd like to add this for handling several features of Google Drive API
that is only available for whitelisted first-party client.
By checking the key by the newly added function, we can provide
better fallbacks for clients with third-party keys, instead of just failing.

BUG=332332, 324166
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245504

[kinaba, 2014-01-17 04:37:32]

+joi: PTAL.
Let me know if you think there is a better way to handle such a case.

[Jói, 2014-01-17 08:44:10]

LGTM, this seems like the best approach.

On Fri, Jan 17, 2014 at 5:37 AM,  <kinaba@chromium.org> wrote:
> Reviewers: Jói,
>
> Message:
> +joi: PTAL.
> Let me know if you think there is a better way to handle such a case.
>
> Description:
> Add a function for determining if official Google Chrome API key is used.
>
> I'd like to add this for handling several features of Google Drive API
> that is only available for whitelisted first-party client.
> By checking the key by the newly added function, we can provide
> better fallbacks for clients with third-party keys, instead of just failing.
>
> BUG=332332, 324166
>
> Please review this at https://codereview.chromium.org/131743018/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+12, -0 lines):
>   M google_apis/google_api_keys.h
>   M google_apis/google_api_keys.cc
>
>
> Index: google_apis/google_api_keys.cc
> diff --git a/google_apis/google_api_keys.cc b/google_apis/google_api_keys.cc
> index
>
94f6812ab7494f0534857b92a5a6b6fefca4d83e..2cf92fd0bf9ea623ff4f3e4e66c2a2c2dcafa032
> 100644
> --- a/google_apis/google_api_keys.cc
> +++ b/google_apis/google_api_keys.cc
> @@ -269,4 +269,12 @@ std::string GetOAuth2ClientSecret(OAuth2Client client)
> {
>    return g_api_key_cache.Get().GetClientSecret(client);
>  }
>
> +bool IsGoogleChromeAPIKeyUsed() {
> +#if defined(GOOGLE_CHROME_BUILD) || defined(USE_OFFICIAL_GOOGLE_API_KEYS)
> +  return true;
> +#else
> +  return false;
> +#endif
> +}
> +
>  }  // namespace google_apis
> Index: google_apis/google_api_keys.h
> diff --git a/google_apis/google_api_keys.h b/google_apis/google_api_keys.h
> index
>
8f4bc7e9cacded2d94d0f9c697b87cfb0de42d08..5acdf263a6ffb9c58c191df6accbc567c6040abf
> 100644
> --- a/google_apis/google_api_keys.h
> +++ b/google_apis/google_api_keys.h
> @@ -90,6 +90,10 @@ std::string GetOAuth2ClientID(OAuth2Client client);
>  // in, e.g. URL-escaped if you use it in a URL.
>  std::string GetOAuth2ClientSecret(OAuth2Client client);
>
> +// Returns if the API key using in the current build is the one for
> official
> +// Google Chrome.
> +bool IsGoogleChromeAPIKeyUsed();
> +
>  }  // namespace google_apis
>
>  #endif  // GOOGLE_APIS_GOOGLE_API_KEYS_H_
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-01-17 08:46:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/131743018/1

[commit-bot: I haz the power, 2014-01-17 13:55:24]

Change committed as 245504