Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 131743012: Merged r18293, r18294, r18295, r18328 into 3.23 branch. (Closed)

Created:
6 years, 11 months ago by palfia
Modified:
6 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Merged r18293, r18294, r18295, r18328 into 3.23 branch. MIPS: Fix patching the receiver (global object -> global proxy) after the interceptor. MIPS: Properly restore the receiver after the interceptor call. MIPS: Fix popping order on ARM. MIPS: Move the receiver into r0 for PatchGlobalProxy. R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18628

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M src/mips/stub-cache-mips.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
palfia
6 years, 11 months ago (2014-01-15 17:59:55 UTC) #1
palfia
PTAL.
6 years, 11 months ago (2014-01-15 18:00:33 UTC) #2
Jakob Kummerow
lgtm
6 years, 11 months ago (2014-01-15 18:01:21 UTC) #3
palfia
Committed patchset #1 manually as r18628 (presubmit successful).
6 years, 11 months ago (2014-01-15 18:11:32 UTC) #4
Toon Verwaest
6 years, 11 months ago (2014-01-15 19:08:37 UTC) #5
Message was sent while issue was closed.
Thanks for merging this. I overlooked the mips patches, my apologies.

Powered by Google App Engine
This is Rietveld 408576698