Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1317403002: Make Date.prototype an ordinary object (Closed)

Created:
5 years, 3 months ago by Dan Ehrenberg
Modified:
5 years, 3 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make Date.prototype an ordinary object This is a change for ES2015. Date objects have mutable state, so having a mutable prototype is bad for SES requirements, and it is an inconsistency from the typical ES2015 class style of objects BUG=v8:4004 LOG=Y R=adamk Committed: https://crrev.com/f65e61ef447d7e273e9af5c10f3e5e2e3089ea66 Cr-Commit-Position: refs/heads/master@{#30486}

Patch Set 1 #

Patch Set 2 : reorder tests so they pass #

Patch Set 3 : test262 test passes #

Patch Set 4 : Disable outdated test262 test #

Patch Set 5 : disable mozilla tests #

Patch Set 6 : fix mozilla test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M src/date.js View 2 chunks +2 lines, -1 line 0 comments Download
M test/mjsunit/date.js View 1 1 chunk +5 lines, -0 lines 0 comments Download
M test/mozilla/mozilla.status View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M test/test262-es6/test262-es6.status View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M test/test262/test262.status View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317403002/1
5 years, 3 months ago (2015-08-28 21:36:54 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/9113)
5 years, 3 months ago (2015-08-28 21:47:09 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317403002/20001
5 years, 3 months ago (2015-08-28 22:14:56 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/9193)
5 years, 3 months ago (2015-08-28 22:43:54 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317403002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317403002/40001
5 years, 3 months ago (2015-08-28 22:56:13 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317403002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317403002/60001
5 years, 3 months ago (2015-08-28 23:35:26 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/9114)
5 years, 3 months ago (2015-08-29 00:14:07 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317403002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317403002/80001
5 years, 3 months ago (2015-08-29 00:59:05 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/9116)
5 years, 3 months ago (2015-08-29 01:46:14 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317403002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317403002/100001
5 years, 3 months ago (2015-08-31 19:02:05 UTC) #20
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-31 19:24:28 UTC) #22
Dan Ehrenberg
5 years, 3 months ago (2015-08-31 20:39:45 UTC) #23
adamk
lgtm
5 years, 3 months ago (2015-08-31 20:40:57 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317403002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317403002/100001
5 years, 3 months ago (2015-08-31 20:44:18 UTC) #26
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 3 months ago (2015-08-31 20:45:42 UTC) #27
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 20:46:01 UTC) #28
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/f65e61ef447d7e273e9af5c10f3e5e2e3089ea66
Cr-Commit-Position: refs/heads/master@{#30486}

Powered by Google App Engine
This is Rietveld 408576698