Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1317333003: Moves initialization of exception handler registration (Closed)

Created:
5 years, 3 months ago by sky
Modified:
5 years, 3 months ago
Reviewers:
yzshen1, yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves initialization of exception handler registration Registering exception handlers is per-process, not per thread. The old code was doing the registration per mojo-app, which is per thread. This is problematic for a couple of reasons, but primarily because an app may be unloaded, which results in the system having an exception handler pointing to a now invalid location. The fix is to move registration to the place where we launch applications, which happens only once per process. BUG=526245 TEST=none R=yzshen1@chromium.org Committed: https://crrev.com/03c235bfc0ff5db46f82463fa471bc8ad5236053 Cr-Commit-Position: refs/heads/master@{#346240}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add include #

Patch Set 3 : update android #

Patch Set 4 : add include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M mojo/application/public/cpp/lib/application_runner.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M mojo/runner/android/main.cc View 1 2 3 chunks +6 lines, -0 lines 0 comments Download
M mojo/runner/desktop/main.cc View 1 2 3 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
sky
5 years, 3 months ago (2015-08-28 19:37:17 UTC) #1
yzshen1
LGTM with one nit https://codereview.chromium.org/1317333003/diff/1/mojo/runner/desktop/main.cc File mojo/runner/desktop/main.cc (right): https://codereview.chromium.org/1317333003/diff/1/mojo/runner/desktop/main.cc#newcode21 mojo/runner/desktop/main.cc:21: Please consider including build/build_config.h.
5 years, 3 months ago (2015-08-28 19:43:22 UTC) #3
sky
https://codereview.chromium.org/1317333003/diff/1/mojo/runner/desktop/main.cc File mojo/runner/desktop/main.cc (right): https://codereview.chromium.org/1317333003/diff/1/mojo/runner/desktop/main.cc#newcode21 mojo/runner/desktop/main.cc:21: On 2015/08/28 19:43:22, yzshen1 wrote: > Please consider including ...
5 years, 3 months ago (2015-08-28 19:53:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317333003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317333003/20001
5 years, 3 months ago (2015-08-28 19:53:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317333003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317333003/40001
5 years, 3 months ago (2015-08-28 20:04:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317333003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317333003/60001
5 years, 3 months ago (2015-08-28 20:55:59 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-08-28 21:46:54 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 21:47:39 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/03c235bfc0ff5db46f82463fa471bc8ad5236053
Cr-Commit-Position: refs/heads/master@{#346240}

Powered by Google App Engine
This is Rietveld 408576698