Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1317333002: Reland [Startup Tracing] Add --trace-config-file flag (Closed)

Created:
5 years, 3 months ago by Zhen Wang
Modified:
5 years, 3 months ago
CC:
chromium-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, wfh+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, penghuang+watch-mandoline_chromium.org, tracing+reviews_chromium.org, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland [Startup Tracing] Add --trace-config-file flag Original CL: https://codereview.chromium.org/1315463002/ This CL adds --trace-config-file flag. Please see trace_config_file.h for details. Design doc: https://docs.google.com/document/d/1PgdXUOJF3WtEmYWUyGRbC2Fz2ICCZKO9jPvpLPRSHH8/edit?usp=sharing BUG=317481, 482098 TBR=dsinclair@chromium.org,blundell@chromium.org,sievers@chromium.org,sky@chromium.org,msw@chromium.org Committed: https://crrev.com/a556ab616a3817468a9bd2163383dafe24ffdc96 Cr-Commit-Position: refs/heads/master@{#346189}

Patch Set 1 : patch original CL 1315463002 #

Patch Set 2 : fix unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+583 lines, -143 lines) Patch
M components/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/components_tests.gyp View 3 chunks +5 lines, -0 lines 0 comments Download
M components/tracing.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M components/tracing/BUILD.gn View 2 chunks +16 lines, -2 lines 0 comments Download
D components/tracing/startup_tracing.h View 1 chunk +0 lines, -20 lines 0 comments Download
D components/tracing/startup_tracing.cc View 1 chunk +0 lines, -66 lines 0 comments Download
A components/tracing/trace_config_file.h View 1 chunk +94 lines, -0 lines 0 comments Download
A components/tracing/trace_config_file.cc View 1 chunk +140 lines, -0 lines 0 comments Download
A components/tracing/trace_config_file_unittest.cc View 1 1 chunk +220 lines, -0 lines 0 comments Download
M components/tracing/tracing_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/tracing/tracing_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/tracing_nacl.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M content/app/android/library_loader_hooks.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M content/app/content_main_runner.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/browser_main_loop.h View 5 chunks +7 lines, -5 lines 0 comments Download
M content/browser/browser_main_loop.cc View 5 chunks +43 lines, -27 lines 0 comments Download
M content/browser/browser_main_runner.cc View 2 chunks +19 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/plugin_process_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mandoline/app/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/app/desktop/launcher_process.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M mojo/runner/desktop/launcher_process.cc View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Zhen Wang
FYI. I'm CQ'ing this TBR'd since the only diff relative to the previously-reviewed patch set ...
5 years, 3 months ago (2015-08-28 18:19:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317333002/20001
5 years, 3 months ago (2015-08-28 18:20:29 UTC) #4
msw
lgtm
5 years, 3 months ago (2015-08-28 18:20:44 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-28 18:27:36 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a556ab616a3817468a9bd2163383dafe24ffdc96 Cr-Commit-Position: refs/heads/master@{#346189}
5 years, 3 months ago (2015-08-28 18:28:21 UTC) #7
sergeyv
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1312833007/ by sergeyv@chromium.org. ...
5 years, 3 months ago (2015-08-28 19:09:39 UTC) #8
Zhen Wang
5 years, 3 months ago (2015-08-28 19:14:15 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1314823005/ by zhenw@chromium.org.

The reason for reverting is: This CL causes problem on Win X64 GN dbg again. Not
sure why. Cannot test on trybot either because there are some other trybot
issues. Will revert this CL for now and wait until the waterfall is entirely
green again for further testing.

http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20GN%2....

Powered by Google App Engine
This is Rietveld 408576698