Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1317263007: Port SkLazyFnPtr users to SkOncePtr. (Closed)

Created:
5 years, 3 months ago by mtklein_C
Modified:
5 years, 3 months ago
Reviewers:
herb_g, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Port SkLazyFnPtr users to SkOncePtr. First baby step on road to replacing SkLazyFnPtr, SkLazyPtr, and SkOnce. One of those very unusual times you get to use a function type, not a function pointer type! BUG=skia: Committed: https://skia.googlesource.com/skia/+/bbd40183ae5f5dd3ae6e8ad3cf89cf5c27ce754b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -88 lines) Patch
D src/core/SkLazyFnPtr.h View 1 chunk +0 lines, -66 lines 0 comments Download
M src/ports/SkFontHost_mac.cpp View 4 chunks +15 lines, -22 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317263007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317263007/1
5 years, 3 months ago (2015-09-08 13:27:42 UTC) #2
mtklein_C
This is an easy one.
5 years, 3 months ago (2015-09-08 13:28:44 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-08 13:37:06 UTC) #6
herb_g
lgtm
5 years, 3 months ago (2015-09-08 14:29:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317263007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317263007/1
5 years, 3 months ago (2015-09-08 15:19:01 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 15:19:37 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bbd40183ae5f5dd3ae6e8ad3cf89cf5c27ce754b

Powered by Google App Engine
This is Rietveld 408576698