Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1317163003: Fix a mouse lock problem on Windows where in clicks outside the web page would also cause mouse loc… (Closed)

Created:
5 years, 3 months ago by ananta
Modified:
5 years, 3 months ago
Reviewers:
scheib
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a mouse lock problem on Windows where in clicks outside the web page would also cause mouse lock to happen. This fixes an issue with the mouse locking code on Windows where in if a page entered a mouse lock state and exited it via the Esc key, subsequently clicking outside the page would cause the lock prompt to display again. This was because RenderWidgetHostViewAura grabs capture on all platforms including Windows. On Windows the capture happens elsewhere in the mouse handler. However when the mouse release comes in it is possible that we are already in the mouse locked state and hence the capture is never released. Fix is to release capture on all platforms. BUG=526378 R=scheib

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -13 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 4 chunks +7 lines, -13 lines 0 comments Download

Depends on Patchset:

Powered by Google App Engine
This is Rietveld 408576698