Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1317123003: [turbofan] Fix unified stack slots for embedded constant pools. (Closed)

Created:
5 years, 3 months ago by MTBrandyberry
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix unified stack slots for embedded constant pools. Account for the constant pool pointer slot during register allocation data initialization. R=danno@chromium.org, titzer@chromium.org, bmeurer@chromium.org, mcilroy@chromium.org, TEST=cctest/test-run-machops/RunSpillConstantsAndParameters BUG= Committed: https://crrev.com/28f07b1c2b62d0757180efdee898016d61e434c1 Cr-Commit-Position: refs/heads/master@{#30430}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/compiler/pipeline.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/frames.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
MTBrandyberry
5 years, 3 months ago (2015-08-27 18:02:49 UTC) #2
MTBrandyberry
On 2015/08/27 18:02:49, mtbrandyberry wrote: This fix resolves the current set of buildbot test failures ...
5 years, 3 months ago (2015-08-27 19:59:31 UTC) #3
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-08-28 05:49:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317123003/1
5 years, 3 months ago (2015-08-28 05:49:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-28 06:35:01 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 06:35:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28f07b1c2b62d0757180efdee898016d61e434c1
Cr-Commit-Position: refs/heads/master@{#30430}

Powered by Google App Engine
This is Rietveld 408576698