Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1317113007: [es6] add js-perf-test for rest parameters (Closed)

Created:
5 years, 3 months ago by caitp (gmail)
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] add js-perf-test for rest parameters BUG=v8:2160 LOG=N R=adamk, rossberg, wingo Committed: https://crrev.com/ce95a4db6995c824d52098b2ca05b162ee9ff6cc Cr-Commit-Position: refs/heads/master@{#30647}

Patch Set 1 #

Patch Set 2 : Fix those suite names #

Patch Set 3 : Fix typo #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -2 lines) Patch
M test/js-perf-test/JSTests.json View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
A test/js-perf-test/RestParameters/rest.js View 1 1 chunk +30 lines, -0 lines 1 comment Download
A + test/js-perf-test/RestParameters/run.js View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
caitp (gmail)
PTAL, it's a basic test, a simplified port of the microbenchmark I wrote on jsperf ...
5 years, 3 months ago (2015-09-05 16:05:47 UTC) #1
adamk
lgtm
5 years, 3 months ago (2015-09-08 22:27:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317113007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317113007/60001
5 years, 3 months ago (2015-09-08 22:50:51 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 3 months ago (2015-09-08 23:17:08 UTC) #7
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/ce95a4db6995c824d52098b2ca05b162ee9ff6cc Cr-Commit-Position: refs/heads/master@{#30647}
5 years, 3 months ago (2015-09-08 23:17:19 UTC) #8
Michael Achenbach
5 years, 3 months ago (2015-09-10 12:24:48 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/1317113007/diff/60001/test/js-perf-test/RestP...
File test/js-perf-test/RestParameters/rest.js (right):

https://codereview.chromium.org/1317113007/diff/60001/test/js-perf-test/RestP...
test/js-perf-test/RestParameters/rest.js:5: new BenchmarkSuite('Basic', [1000],
[
s/Basic/BasicRest1 in the suite name to match the name in

https://codereview.chromium.org/1317113007/diff/60001/test/js-perf-test/JSTes...
line 21

Currently the test result can't be read.

Powered by Google App Engine
This is Rietveld 408576698