Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 1317113004: Reduce the number of entrypoints to the compiler pipeline by one. Always require caller to provide … (Closed)

Created:
5 years, 3 months ago by titzer
Modified:
5 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reduce the number of entrypoints to the compiler pipeline by one. Always require caller to provide a CompilationInfo. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/be8564ba43bc3581ba7f4c3a07416e9ff4499404 Cr-Commit-Position: refs/heads/master@{#30433}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -22 lines) Patch
M src/compiler/pipeline.h View 1 chunk +5 lines, -9 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M test/cctest/compiler/codegen-tester.h View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/compiler/graph-builder-tester.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/compiler/test-run-native-calls.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
titzer
5 years, 3 months ago (2015-08-27 18:40:29 UTC) #1
Michael Starzinger
LGTM. Love it.
5 years, 3 months ago (2015-08-27 19:07:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317113004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317113004/1
5 years, 3 months ago (2015-08-28 09:00:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-28 09:02:15 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 09:02:23 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be8564ba43bc3581ba7f4c3a07416e9ff4499404
Cr-Commit-Position: refs/heads/master@{#30433}

Powered by Google App Engine
This is Rietveld 408576698