Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1317103002: Add trace event to SkPicture analysis. (Closed)

Created:
5 years, 3 months ago by mtklein_C
Modified:
5 years, 3 months ago
Reviewers:
mtklein, vmpstr
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add trace event to SkPicture analysis. RE: https://codereview.chromium.org/1319723002/ This should mark out the time spent to support hasText(), willPlayBackBitmaps(), and numSlowPaths() in about:tracing. BUG=skia: Committed: https://skia.googlesource.com/skia/+/e01008fdbccf64eb17f9efe243afdf7aa3f5bd1d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/core/SkBigPicture.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mtklein_C
Why wonder how slow it is when we can measure? :)
5 years, 3 months ago (2015-08-27 13:47:24 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317103002/1
5 years, 3 months ago (2015-08-27 13:48:10 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-27 13:53:11 UTC) #6
vmpstr
lgtm, thanks!
5 years, 3 months ago (2015-08-27 17:29:30 UTC) #7
mtklein
lgtm
5 years, 3 months ago (2015-08-27 17:38:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317103002/1
5 years, 3 months ago (2015-08-27 17:38:31 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 17:39:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e01008fdbccf64eb17f9efe243afdf7aa3f5bd1d

Powered by Google App Engine
This is Rietveld 408576698