Issue 13171006: Merge 190915 "Fix crash of chrome.fileSystem.chooseEntry on Linux."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13171006: Merge 190915 "Fix crash of chrome.fileSystem.chooseEntry on Linux." (Closed)

Created:
7 years, 8 months ago by benwells

Modified:
7 years, 8 months ago

Reviewers:
kinaba

CC:
chromium-reviews, tzik+watch_chromium.org, Aaron Boodman, kinuko+watch, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1453/src/

Visibility:
Public.

Merge 190915 "Fix crash of chrome.fileSystem.chooseEntry on Linux." > Fix crash of chrome.fileSystem.chooseEntry on Linux. > > I misunderstood FileSelected() is used only from FileSelectedWithExtraInfo(), > but it was wrong. There are situations it is used by itself, > hence NOTREACHED() does not hold at all. > > BUG=224196 > > Review URL: https://chromiumcodereview.appspot.com/13042004 TBR=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191472

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	chrome/browser/extensions/api/file_system/file_system_api.cc	View		2 chunks	+4 lines, -7 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r191472.