Issue 13171005: Merge 146950 "IndexedDB: Histogram cause of LevelDB write errors"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13171005: Merge 146950 "IndexedDB: Histogram cause of LevelDB write errors" (Closed)

Created:
7 years, 8 months ago by dgrogan

Modified:
7 years, 8 months ago

Reviewers:
dgrogan

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1453/

Visibility:
Public.

More Reviews

Description

Merge 146950 "IndexedDB: Histogram cause of LevelDB write errors" > IndexedDB: Histogram cause of LevelDB write errors > https://bugs.webkit.org/show_bug.cgi?id=113350 > > Reviewed by Tony Chang. > > Add histogram for source of LevelDB errors on Write in addition to > Open. > > No new tests - no good way to test histogram code. > > * platform/leveldb/LevelDBDatabase.cpp: > (WebCore::histogramLevelDBError): > (WebCore): > (WebCore::LevelDBDatabase::open): > (WebCore::LevelDBDatabase::write): > TBR=dgrogan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147258

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -16 lines)			Patch
	M	Source/WebCore/platform/leveldb/LevelDBDatabase.cpp	View		3 chunks	+22 lines, -16 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r147258.

Expand Messages | Collapse Messages