Source/core/editing/spellcheck/SpellChecker.cpp - Issue 1317053004: Make VisiblePosition constructor private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/spellcheck/SpellChecker.cpp

Issue 1317053004: Make VisiblePosition constructor private (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-09-02T12:44:47 Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/spellcheck/SpellChecker.cpp

diff --git a/Source/core/editing/spellcheck/SpellChecker.cpp b/Source/core/editing/spellcheck/SpellChecker.cpp

index 9ee443e7985f8a7f346875ed5763e6ebe0c27102..10aa296a26fe40d35e43bc933a038269fe0c9895 100644

--- a/Source/core/editing/spellcheck/SpellChecker.cpp

+++ b/Source/core/editing/spellcheck/SpellChecker.cpp

@@ -212,7 +212,7 @@ void SpellChecker::advanceToNextMisspelling(bool startBeforeSelection)

// next word so we start checking at a word boundary. Going back by one char

// and then forward by a word does the trick.

if (startedWithSelection) {

- VisiblePosition oneBeforeStart = previousPositionOf(VisiblePosition(spellingSearchStart));

+ VisiblePosition oneBeforeStart = previousPositionOf(createVisiblePosition(spellingSearchStart));

if (oneBeforeStart.isNotNull())

spellingSearchStart = endOfWord(oneBeforeStart).toParentAnchoredPosition();

// else we were already at the start of the editable node