Source/core/editing/VisiblePositionTest.cpp - Issue 1317053004: Make VisiblePosition constructor private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/VisiblePositionTest.cpp

Issue 1317053004: Make VisiblePosition constructor private (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-09-01T18:48:19 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/VisiblePositionTest.cpp

diff --git a/Source/core/editing/VisiblePositionTest.cpp b/Source/core/editing/VisiblePositionTest.cpp

index fac6848fa47cdb11b12652c96c61de66371e0d60..f78761c4c33e6bfa53ec7614c4d03345587774d4 100644

--- a/Source/core/editing/VisiblePositionTest.cpp

+++ b/Source/core/editing/VisiblePositionTest.cpp

@@ -27,9 +27,9 @@ TEST_F(VisiblePositionTest, ShadowDistributedNodes)

RefPtrWillBeRawPtr<Element> five = shadowRoot->querySelector("#s5", ASSERT_NO_EXCEPTION);

EXPECT_EQ(Position(one->firstChild(), 0), canonicalPositionOf(Position(one, 0)));

- EXPECT_EQ(Position(one->firstChild(), 0), VisiblePosition(Position(one, 0)).deepEquivalent());

+ EXPECT_EQ(Position(one->firstChild(), 0), createVisiblePosition(Position(one, 0)).deepEquivalent());

EXPECT_EQ(Position(one->firstChild(), 2), canonicalPositionOf(Position(two.get(), 0)));

- EXPECT_EQ(Position(one->firstChild(), 2), VisiblePosition(Position(two.get(), 0)).deepEquivalent());

+ EXPECT_EQ(Position(one->firstChild(), 2), createVisiblePosition(Position(two.get(), 0)).deepEquivalent());

EXPECT_EQ(PositionInComposedTree(five->firstChild(), 2), canonicalPositionOf(PositionInComposedTree(one.get(), 0)));

EXPECT_EQ(Position(five->firstChild(), 2), createVisiblePosition(PositionInComposedTree(one.get(), 0)).deepEquivalent());