Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: Source/core/editing/VisiblePosition.h

Issue 1317053004: Make VisiblePosition constructor private (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-09-01T18:48:19 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/VisiblePosition.h
diff --git a/Source/core/editing/VisiblePosition.h b/Source/core/editing/VisiblePosition.h
index f947efe18edd5a7d5267b9e02a6e68dd0f4096aa..61bc5e580dc805271a85bd46f94f3d78dff3e0cb 100644
--- a/Source/core/editing/VisiblePosition.h
+++ b/Source/core/editing/VisiblePosition.h
@@ -72,11 +72,6 @@ class CORE_EXPORT VisiblePosition final {
public:
VisiblePosition() : m_affinity(VP_DEFAULT_AFFINITY) { }
- // TODO(yosin) We should use |createVisiblePosition()| instead of
- // constructor, and make constructors to have private accessibility, since
- // constructors aren't simple, e.g. they update layout tree.
- explicit VisiblePosition(const Position&, TextAffinity = VP_DEFAULT_AFFINITY);
-
// Node: Other than |createVisiblePosition()|, we should not use
// |createWithoutCanonicalization()|.
static VisiblePosition createWithoutCanonicalization(const PositionWithAffinity& canonicalized);
@@ -106,6 +101,8 @@ public:
#endif
private:
+ explicit VisiblePosition(const Position&, TextAffinity);
+
// TODO(yosin) We should use |PositionWithAffinity| to make
// |toPositionWithAffinity()| simpler.
Position m_deepPosition;

Powered by Google App Engine
This is Rietveld 408576698