Make VisiblePosition constructor private

Source/core/editing/commands/BreakBlockquoteCommand.cpp

 /*
  * Copyright (C) 2005 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 115 matching lines @@
 
     // Don't move a line break just after the caret.  Doing so would create an extra, empty paragraph
     // in the new blockquote.
     if (lineBreakExistsAtVisiblePosition(visiblePos)) {
         // TODO(yosin) We should use |PositionMoveType::Character| for
         // |nextPositionOf()| to avoid editing middle of character.
         pos = nextPositionOf(pos, PositionMoveType::CodePoint);
     }
 
     // Adjust the position so we don't split at the beginning of a quote.
-    while (isFirstVisiblePositionInNode(VisiblePosition(pos), toHTMLQuoteElement(enclosingNodeOfType(pos, isMailHTMLBlockquoteElement)))) {
+    while (isFirstVisiblePositionInNode(createVisiblePosition(pos), toHTMLQuoteElement(enclosingNodeOfType(pos, isMailHTMLBlockquoteElement)))) {
         // TODO(yosin) We should use |PositionMoveType::Character| for
         // |previousPositionOf()| to avoid editing middle character.
         pos = previousPositionOf(pos, PositionMoveType::CodePoint);
     }
 
     // startNode is the first node that we need to move to the new blockquote.
     Node* startNode = pos.anchorNode();
     ASSERT(startNode);
 
     // Split at pos if in the middle of a text node.
     if (startNode->isTextNode()) {
         Text* textNode = toText(startNode);
         int textOffset = pos.computeOffsetInContainerNode();
         if ((unsigned)textOffset >= textNode->length()) {
             startNode = NodeTraversal::next(*startNode);
             ASSERT(startNode);
         } else if (textOffset > 0) {
             splitTextNode(textNode, textOffset);
         }
     } else if (pos.computeEditingOffset() > 0) {
         Node* childAtOffset = NodeTraversal::childAt(*startNode, pos.computeEditingOffset());
         startNode = childAtOffset ? childAtOffset : NodeTraversal::next(*startNode);
         ASSERT(startNode);
     }
 
     // If there's nothing inside topBlockquote to move, we're finished.
     if (!startNode->isDescendantOf(topBlockquote)) {
-        setEndingSelection(VisibleSelection(VisiblePosition(firstPositionInOrBeforeNode(startNode)), endingSelection().isDirectional()));
+        setEndingSelection(VisibleSelection(createVisiblePosition(firstPositionInOrBeforeNode(startNode)), endingSelection().isDirectional()));
         return;
     }
 
     // Build up list of ancestors in between the start node and the top blockquote.
     WillBeHeapVector<RefPtrWillBeMember<Element>> ancestors;
     for (Element* node = startNode->parentElement(); node && node != topBlockquote; node = node->parentElement())
         ancestors.append(node);
 
     // Insert a clone of the top blockquote after the break.
     RefPtrWillBeRawPtr<Element> clonedBlockquote = topBlockquote->cloneElementWithoutChildren();
@@ skipping 43 matching lines @@
 
     // Make sure the cloned block quote renders.
     addBlockPlaceholderIfNeeded(clonedBlockquote.get());
 
     // Put the selection right before the break.
     setEndingSelection(VisibleSelection(positionBeforeNode(breakElement.get()), TextAffinity::Downstream, endingSelection().isDirectional()));
     rebalanceWhitespace();
 }
 
 } // namespace blink