Make VisiblePosition constructor private

Source/core/editing/DOMSelection.cpp

 /*
  * Copyright (C) 2007, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 215 matching lines @@
     if (!m_frame)
         return;
 
     const VisibleSelection& selection = m_frame->selection().selection();
 
     if (selection.isNone()) {
         exceptionState.throwDOMException(InvalidStateError, "there is no selection.");
         return;
     }
 
-    m_frame->selection().moveTo(VisiblePosition(selection.end()));
+    m_frame->selection().moveTo(createVisiblePosition(selection.end()));
 }
 
 void DOMSelection::collapseToStart(ExceptionState& exceptionState)
 {
     if (!m_frame)
         return;
 
     const VisibleSelection& selection = m_frame->selection().selection();
 
     if (selection.isNone()) {
         exceptionState.throwDOMException(InvalidStateError, "there is no selection.");
         return;
     }
 
-    m_frame->selection().moveTo(VisiblePosition(selection.start()));
+    m_frame->selection().moveTo(createVisiblePosition(selection.start()));
 }
 
 void DOMSelection::empty()
 {
     if (!m_frame)
         return;
     m_frame->selection().clear();
 }
 
 void DOMSelection::setBaseAndExtent(Node* baseNode, int baseOffset, Node* extentNode, int extentOffset, ExceptionState& exceptionState)
 {
     if (!m_frame)
         return;
 
     if (baseOffset < 0) {
         exceptionState.throwDOMException(IndexSizeError, String::number(baseOffset) + " is not a valid base offset.");
         return;
     }
 
     if (extentOffset < 0) {
         exceptionState.throwDOMException(IndexSizeError, String::number(extentOffset) + " is not a valid extent offset.");
         return;
     }
 
     if (!isValidForPosition(baseNode) || !isValidForPosition(extentNode))
         return;
 
-    VisiblePosition visibleBase = VisiblePosition(Position(baseNode, baseOffset));
-    VisiblePosition visibleExtent = VisiblePosition(Position(extentNode, extentOffset));
+    VisiblePosition visibleBase = createVisiblePosition(Position(baseNode, baseOffset));
+    VisiblePosition visibleExtent = createVisiblePosition(Position(extentNode, extentOffset));
 
     m_frame->selection().moveTo(visibleBase, visibleExtent);
 }
 
 void DOMSelection::modify(const String& alterString, const String& directionString, const String& granularityString)
 {
     if (!m_frame)
         return;
 
     FrameSelection::EAlteration alter;
@@ skipping 53 matching lines @@
         return;
     }
     if (static_cast<unsigned>(offset) > node->lengthOfContents()) {
         exceptionState.throwDOMException(IndexSizeError, String::number(offset) + " is larger than the given node's length.");
         return;
     }
 
     if (!isValidForPosition(node))
         return;
 
-    m_frame->selection().setExtent(VisiblePosition(Position(node, offset)));
+    m_frame->selection().setExtent(createVisiblePosition(Position(node, offset)));
 }
 
 PassRefPtrWillBeRawPtr<Range> DOMSelection::getRangeAt(int index, ExceptionState& exceptionState)
 {
     if (!m_frame)
         return nullptr;
 
     if (index < 0 || index >= rangeCount()) {
         exceptionState.throwDOMException(IndexSizeError, String::number(index) + " is not a valid index.");
         return nullptr;
@@ skipping 191 matching lines @@
         m_treeScope->document().addConsoleMessage(ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, message));
 }
 
 DEFINE_TRACE(DOMSelection)
 {
     visitor->trace(m_treeScope);
     DOMWindowProperty::trace(visitor);
 }
 
 } // namespace blink