LayoutTests/http/tests/credentialmanager/passwordcredential-basics.html - Issue 1317043003: CREDENTIAL: Add 'PasswordCredential::toFormData()'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/credentialmanager/passwordcredential-basics.html

Issue 1317043003: CREDENTIAL: Add 'PasswordCredential::toFormData()' (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@opaque-formdata

Patch Set: FormDataOptions Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html ('k') | Source/modules/credentialmanager/FormDataOptions.idl » ('j') | Source/modules/credentialmanager/PasswordCredential.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/credentialmanager/passwordcredential-basics.html

diff --git a/LayoutTests/http/tests/credentialmanager/passwordcredential-basics.html b/LayoutTests/http/tests/credentialmanager/passwordcredential-basics.html

index 6b928ea49287c10d6b7713dc2555cebd58dd6bde..ca3b8a7d05ffeee2477678ef317a229637db802f 100644

--- a/LayoutTests/http/tests/credentialmanager/passwordcredential-basics.html

+++ b/LayoutTests/http/tests/credentialmanager/passwordcredential-basics.html

@@ -8,20 +8,18 @@ test(function() {

var credential = new PasswordCredential('id', 'pencil', 'name', 'https://example.com/icon.png');

verify_interface('PasswordCredential', credential, {

- formData: 'object',

id: 'string',

name: 'string',

iconURL: 'string',

- password: 'string',

type: 'string'

});

- assert_true(credential.formData instanceof FormData);

assert_equals(credential.id, 'id');

assert_equals(credential.name, 'name');

assert_equals(credential.iconURL, 'https://example.com/icon.png');

- assert_equals(credential.password, 'pencil');

assert_equals(credential.type, 'password');

+ assert_true(credential.toFormData() instanceof FormData);

}, 'Interfaces and attributes of PasswordCredential');

test(function() {

@@ -36,8 +34,8 @@ test(function() {

assert_equals(credential.id, 'id');

assert_equals(credential.name, 'name');

assert_equals(credential.iconURL, '');

- assert_equals(credential.password, 'pencil');

assert_equals(credential.type, 'password');

+ assert_true(credential.toFormData() instanceof FormData);

}, 'Construct a PasswordCredential with an empty icon URL.');

@@ -47,8 +45,8 @@ test(function() {

assert_equals(credential.id, 'id');

assert_equals(credential.name, '');

assert_equals(credential.iconURL, '');

- assert_equals(credential.password, 'pencil');

assert_equals(credential.type, 'password');

+ assert_true(credential.toFormData() instanceof FormData);

}, 'Construct a PasswordCredential with an empty name and icon URL.');

</script>