Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 1317033006: Linux: Do not use a hard coded app name for PulseAudio output. (Closed)

Created:
5 years, 3 months ago by Lei Zhang
Modified:
5 years, 3 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux: Do not use a hard coded app name for PulseAudio output. BUG=526807 Committed: https://crrev.com/d2efdad3f588b423d284a141999aeac8d2e82dd1 Cr-Commit-Position: refs/heads/master@{#346965}

Patch Set 1 #

Patch Set 2 : nit #

Patch Set 3 : fix chromeos #

Total comments: 1

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -10 lines) Patch
M chrome/browser/chrome_browser_main_linux.cc View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M media/audio/audio_manager.h View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M media/audio/audio_manager.cc View 1 2 3 5 chunks +32 lines, -5 lines 0 comments Download
M media/audio/pulse/pulse_output.cc View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M media/audio/pulse/pulse_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/audio/pulse/pulse_util.cc View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Lei Zhang
5 years, 3 months ago (2015-09-02 00:40:43 UTC) #2
DaleCurtis
Thanks for fixing! I wonder if we can put this in audio_manager.h and audio_manager.cc instead ...
5 years, 3 months ago (2015-09-02 02:38:21 UTC) #3
Lei Zhang
Done, see patch set 4.
5 years, 3 months ago (2015-09-02 06:16:39 UTC) #4
DaleCurtis
lgtm, thanks!
5 years, 3 months ago (2015-09-02 16:08:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317033006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317033006/60001
5 years, 3 months ago (2015-09-02 17:35:45 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-02 18:03:19 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 18:04:02 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d2efdad3f588b423d284a141999aeac8d2e82dd1
Cr-Commit-Position: refs/heads/master@{#346965}

Powered by Google App Engine
This is Rietveld 408576698