Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1317013002: Move GN grit scripts out of secondary tree. (Closed)

Created:
5 years, 3 months ago by brettw
Modified:
5 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move GN grit scripts out of secondary tree. These build files were in the secondary tree because I thought tools/grit was DEPSed in. However, this directory is in the Chrome tree. The DEPSed-in directory is tools/grit/grit. Moving these files to the expected place will make things more clear. Committed: https://crrev.com/82d10f697a4268dd9ae0fffd8f3dfb1fb42901e5 Cr-Commit-Position: refs/heads/master@{#345713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, -609 lines) Patch
D build/secondary/tools/grit/BUILD.gn View 1 chunk +0 lines, -27 lines 0 comments Download
D build/secondary/tools/grit/grit_rule.gni View 1 chunk +0 lines, -482 lines 0 comments Download
D build/secondary/tools/grit/repack.gni View 1 chunk +0 lines, -47 lines 0 comments Download
D build/secondary/tools/grit/stamp_grit_sources.py View 1 chunk +0 lines, -55 lines 0 comments Download
A + tools/grit/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + tools/grit/grit_rule.gni View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/grit/repack.gni View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/grit/stamp_grit_sources.py View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
brettw
5 years, 3 months ago (2015-08-26 17:57:06 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317013002/1
5 years, 3 months ago (2015-08-26 17:58:26 UTC) #4
Nico
lgtm
5 years, 3 months ago (2015-08-26 18:01:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317013002/1
5 years, 3 months ago (2015-08-26 18:05:27 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/104806)
5 years, 3 months ago (2015-08-26 18:15:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317013002/1
5 years, 3 months ago (2015-08-26 18:19:10 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/95425) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years, 3 months ago (2015-08-26 18:22:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317013002/1
5 years, 3 months ago (2015-08-26 19:12:17 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/98934)
5 years, 3 months ago (2015-08-26 21:12:42 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317013002/1
5 years, 3 months ago (2015-08-26 21:59:42 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-26 23:06:18 UTC) #21
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/82d10f697a4268dd9ae0fffd8f3dfb1fb42901e5 Cr-Commit-Position: refs/heads/master@{#345713}
5 years, 3 months ago (2015-08-26 23:07:35 UTC) #22
brettw
5 years, 3 months ago (2015-08-27 18:16:09 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1311133008/ by brettw@chromium.org.

The reason for reverting is: Apparently this was incorrect..

Powered by Google App Engine
This is Rietveld 408576698