Issue 1317003002: Fixed (more) layout tests to be scroll order agnostic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1317003002: Fixed (more) layout tests to be scroll order agnostic (Closed)

Created:
5 years, 3 months ago by bokan

Modified:
5 years, 3 months ago

Reviewers:
majidvp

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Fixed (more) layout tests to be scroll order agnostic This is needed as a prerequisite to making "visual viewport scrolls first" the default. Scrolling the page before setting scale means that the layout viewport is the only one that could scroll. Note, this is patching 2 tests I missed in my original patch: http://crrev.com/1301523006 BUG=443724 TBR=majidvp@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201236

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	LayoutTests/fast/repaint/fixed-in-page-scale.html	View		1 chunk	+3 lines, -2 lines	0 comments	Download
	M	LayoutTests/fast/repaint/fixed-right-in-page-scale.html	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317003002/1

5 years, 3 months ago (2015-08-26 16:44:34 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201236

5 years, 3 months ago (2015-08-26 17:26:15 UTC) #3

majidvp

5 years, 3 months ago (2015-08-26 17:32:55 UTC) #4

Message was sent while issue was closed.

On 2015/08/26 17:26:15, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
> https://src.chromium.org/viewvc/blink?view=rev&revision=201236

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages