Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/compiler/pipeline.cc

Issue 1316943002: Move (uppercase) JS builtins from js builtins object to native context. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: remove Isolate::js_builtins_object Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/js-generic-lowering.cc ('k') | src/contexts.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/pipeline.h" 5 #include "src/compiler/pipeline.h"
6 6
7 #include <fstream> // NOLINT(readability/streams) 7 #include <fstream> // NOLINT(readability/streams)
8 #include <sstream> 8 #include <sstream>
9 9
10 #include "src/base/adapters.h" 10 #include "src/base/adapters.h"
(...skipping 972 matching lines...) Expand 10 before | Expand all | Expand 10 after
983 if (FLAG_turbo_verify) { 983 if (FLAG_turbo_verify) {
984 Run<VerifyGraphPhase>(untyped); 984 Run<VerifyGraphPhase>(untyped);
985 } 985 }
986 } 986 }
987 987
988 988
989 Handle<Code> Pipeline::GenerateCode() { 989 Handle<Code> Pipeline::GenerateCode() {
990 // TODO(mstarzinger): This is just a temporary hack to make TurboFan work, 990 // TODO(mstarzinger): This is just a temporary hack to make TurboFan work,
991 // the correct solution is to restore the context register after invoking 991 // the correct solution is to restore the context register after invoking
992 // builtins from full-codegen. 992 // builtins from full-codegen.
993 for (int i = 0; i < Builtins::NumberOfJavaScriptBuiltins(); i++) { 993 if (Context::IsJSBuiltin(isolate()->native_context(), info()->closure())) {
994 Builtins::JavaScript id = static_cast<Builtins::JavaScript>(i); 994 return Handle<Code>::null();
995 Object* builtin = isolate()->js_builtins_object()->javascript_builtin(id);
996 if (*info()->closure() == builtin) return Handle<Code>::null();
997 } 995 }
998 996
999 ZonePool zone_pool; 997 ZonePool zone_pool;
1000 base::SmartPointer<PipelineStatistics> pipeline_statistics; 998 base::SmartPointer<PipelineStatistics> pipeline_statistics;
1001 999
1002 if (FLAG_turbo_stats) { 1000 if (FLAG_turbo_stats) {
1003 pipeline_statistics.Reset(new PipelineStatistics(info(), &zone_pool)); 1001 pipeline_statistics.Reset(new PipelineStatistics(info(), &zone_pool));
1004 pipeline_statistics->BeginPhaseKind("initializing"); 1002 pipeline_statistics->BeginPhaseKind("initializing");
1005 } 1003 }
1006 1004
(...skipping 397 matching lines...) Expand 10 before | Expand all | Expand 10 after
1404 tcf << AsC1VRegisterAllocationData("CodeGen", 1402 tcf << AsC1VRegisterAllocationData("CodeGen",
1405 data->register_allocation_data()); 1403 data->register_allocation_data());
1406 } 1404 }
1407 1405
1408 data->DeleteRegisterAllocationZone(); 1406 data->DeleteRegisterAllocationZone();
1409 } 1407 }
1410 1408
1411 } // namespace compiler 1409 } // namespace compiler
1412 } // namespace internal 1410 } // namespace internal
1413 } // namespace v8 1411 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/js-generic-lowering.cc ('k') | src/contexts.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698