Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: test/cctest/test-api.cc

Issue 1316933002: [es6] Initial steps towards a correct implementation of IsCallable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: ia32, arm and arm64 ports. Misc cleanups. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/runtime/runtime-classes.cc ('K') | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index 76f3304317ca2050c90ed58fed8471344358b7ac..7ccb0ee52573ea6486985aad29b7f6fa4d298485 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -9795,8 +9795,8 @@ THREADED_TEST(ConstructorForObject) {
value = instance->CallAsConstructor(1, args);
CHECK(try_catch.HasCaught());
String::Utf8Value exception_value2(try_catch.Exception());
- CHECK_EQ(
- 0, strcmp("TypeError: #<Object> is not a function", *exception_value2));
+ CHECK_EQ(0,
+ strcmp("TypeError: object is not a function", *exception_value2));
Michael Starzinger 2015/08/27 10:47:14 This will most likely hit blink layout tests. Bett
try_catch.Reset();
}
@@ -10165,8 +10165,8 @@ THREADED_TEST(CallAsFunction) {
CHECK(value.IsEmpty());
CHECK(try_catch.HasCaught());
String::Utf8Value exception_value2(try_catch.Exception());
- CHECK_EQ(0, strcmp("TypeError: [object Object] is not a function",
- *exception_value2));
+ CHECK_EQ(0,
+ strcmp("TypeError: object is not a function", *exception_value2));
try_catch.Reset();
}
« src/runtime/runtime-classes.cc ('K') | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698