[es6] Initial steps towards a correct implementation of IsCallable.

src/runtime.js

Index: src/runtime.js
diff --git a/src/runtime.js b/src/runtime.js
index a7218058d7dd24108b769ce412c091dd4d81b542..e561bf601339f2b5fa703b5fdc643612d80c9514 100644
--- a/src/runtime.js
+++ b/src/runtime.js
@@ -437,22 +437,12 @@ function IN(x) {
 
 function CALL_NON_FUNCTION() {
   var delegate = %GetFunctionDelegate(this);
-  if (!IS_FUNCTION(delegate)) {
-    var callsite = %RenderCallSite();
-    if (callsite == "") callsite = typeof this;
-    throw %make_type_error(kCalledNonCallable, callsite);
-  }
   return %Apply(delegate, this, arguments, 0, %_ArgumentsLength());
 }
 
 
 function CALL_NON_FUNCTION_AS_CONSTRUCTOR() {
   var delegate = %GetConstructorDelegate(this);
-  if (!IS_FUNCTION(delegate)) {
-    var callsite = %RenderCallSite();
-    if (callsite == "") callsite = typeof this;
-    throw %make_type_error(kCalledNonCallable, callsite);
-  }
   return %Apply(delegate, this, arguments, 0, %_ArgumentsLength());
 }
 
@@ -480,7 +470,7 @@ function APPLY_PREPARE(args) {
   if (IS_ARRAY(args)) {
     length = args.length;
     if (%_IsSmi(length) && length >= 0 && length < kSafeArgumentsLength &&
-        IS_SPEC_FUNCTION(this)) {
+        IS_CALLABLE(this)) {
       return length;
     }
   }
@@ -492,8 +482,9 @@ function APPLY_PREPARE(args) {
   // multiplying with pointer size.
   if (length > kSafeArgumentsLength) throw %make_range_error(kStackOverflow);
 
-  if (!IS_SPEC_FUNCTION(this)) {
-    throw %make_type_error(kApplyNonFunction, %to_string_fun(this), typeof this);
+  if (!IS_CALLABLE(this)) {
+    throw %make_type_error(kApplyNonFunction, %to_string_fun(this),
+                           typeof this);
   }
 
   // Make sure the arguments list has the right type.
@@ -515,12 +506,12 @@ function REFLECT_APPLY_PREPARE(args) {
   if (IS_ARRAY(args)) {
     length = args.length;
     if (%_IsSmi(length) && length >= 0 && length < kSafeArgumentsLength &&
-        IS_SPEC_FUNCTION(this)) {
+        IS_CALLABLE(this)) {
       return length;
     }
   }
 
-  if (!IS_SPEC_FUNCTION(this)) {
+  if (!IS_CALLABLE(this)) {
     throw %make_type_error(kCalledNonCallable, %to_string_fun(this));
   }
 
@@ -544,8 +535,8 @@ function REFLECT_APPLY_PREPARE(args) {
 function REFLECT_CONSTRUCT_PREPARE(
     args, newTarget) {
   var length;
-  var ctorOk = IS_SPEC_FUNCTION(this) && %IsConstructor(this);
-  var newTargetOk = IS_SPEC_FUNCTION(newTarget) && %IsConstructor(newTarget);
+  var ctorOk = IS_CALLABLE(this) && %IsConstructor(this);
+  var newTargetOk = IS_CALLABLE(newTarget) && %IsConstructor(newTarget);
 
   // First check whether length is a positive Smi and args is an
   // array. This is the fast case. If this fails, we do the slow case
@@ -559,7 +550,7 @@ function REFLECT_CONSTRUCT_PREPARE(
   }
 
   if (!ctorOk) {
-    if (!IS_SPEC_FUNCTION(this)) {
+    if (!IS_CALLABLE(this)) {
       throw %make_type_error(kCalledNonCallable, %to_string_fun(this));
     } else {
       throw %make_type_error(kNotConstructor, %to_string_fun(this));
@@ -567,7 +558,7 @@ function REFLECT_CONSTRUCT_PREPARE(
   }
 
   if (!newTargetOk) {
-    if (!IS_SPEC_FUNCTION(newTarget)) {
+    if (!IS_CALLABLE(newTarget)) {
       throw %make_type_error(kCalledNonCallable, %to_string_fun(newTarget));
     } else {
       throw %make_type_error(kNotConstructor, %to_string_fun(newTarget));
@@ -771,14 +762,14 @@ function IsConcatSpreadable(O) {
 // ECMA-262, section 8.6.2.6, page 28.
 function DefaultNumber(x) {
   var valueOf = x.valueOf;
-  if (IS_SPEC_FUNCTION(valueOf)) {
+  if (IS_CALLABLE(valueOf)) {
     var v = %_CallFunction(x, valueOf);
     if (IS_SYMBOL(v)) throw MakeTypeError(kSymbolToNumber);
     if (IS_SIMD_VALUE(x)) throw MakeTypeError(kSimdToNumber);
     if (IsPrimitive(v)) return v;
   }
   var toString = x.toString;
-  if (IS_SPEC_FUNCTION(toString)) {
+  if (IS_CALLABLE(toString)) {
     var s = %_CallFunction(x, toString);
     if (IsPrimitive(s)) return s;
   }
@@ -790,13 +781,13 @@ function DefaultString(x) {
   if (!IS_SYMBOL_WRAPPER(x)) {
     if (IS_SYMBOL(x)) throw MakeTypeError(kSymbolToString);
     var toString = x.toString;
-    if (IS_SPEC_FUNCTION(toString)) {
+    if (IS_CALLABLE(toString)) {
       var s = %_CallFunction(x, toString);
       if (IsPrimitive(s)) return s;
     }
 
     var valueOf = x.valueOf;
-    if (IS_SPEC_FUNCTION(valueOf)) {
+    if (IS_CALLABLE(valueOf)) {
       var v = %_CallFunction(x, valueOf);
       if (IsPrimitive(v)) return v;
     }