Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: src/objects-debug.cc

Issue 1316933002: [es6] Initial steps towards a correct implementation of IsCallable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: ia32, arm and arm64 ports. Misc cleanups. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects-debug.cc
diff --git a/src/objects-debug.cc b/src/objects-debug.cc
index 961ad51f61bd9a05407a3b39914f15d9e8fba740..df9045b3f036de6c3b0d83ee0de0cb21273349b5 100644
--- a/src/objects-debug.cc
+++ b/src/objects-debug.cc
@@ -36,6 +36,7 @@ void Object::VerifyPointer(Object* p) {
void Smi::SmiVerify() {
CHECK(IsSmi());
+ CHECK(!IsCallable());
Michael Starzinger 2015/08/27 10:47:14 This CHECK does not really verify the Smi value, b
}
@@ -531,6 +532,7 @@ void JSFunction::JSFunctionVerify() {
CHECK(next_function_link() == NULL ||
next_function_link()->IsUndefined() ||
next_function_link()->IsJSFunction());
+ CHECK(map()->is_callable());
}
@@ -809,6 +811,7 @@ void JSFunctionProxy::JSFunctionProxyVerify() {
JSProxyVerify();
VerifyPointer(call_trap());
VerifyPointer(construct_trap());
+ CHECK(map()->is_callable());
}

Powered by Google App Engine
This is Rietveld 408576698