Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: src/execution.h

Issue 1316933002: [es6] Initial steps towards a correct implementation of IsCallable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: ia32, arm and arm64 ports. Misc cleanups. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/execution.h
diff --git a/src/execution.h b/src/execution.h
index 2c07a64aaecc5409064ba1bc5eaf2f2edcf73880..86ecded3027ff9650b5792aeb19bfd5a19c9f841 100644
--- a/src/execution.h
+++ b/src/execution.h
@@ -100,25 +100,23 @@ class Execution final : public AllStatic {
MUST_USE_RESULT static MaybeHandle<JSRegExp> NewJSRegExp(
Handle<String> pattern, Handle<String> flags);
- static Handle<Object> GetFunctionFor();
static Handle<String> GetStackTraceLine(Handle<Object> recv,
Handle<JSFunction> fun,
Handle<Object> pos,
Handle<Object> is_global);
- // Get a function delegate (or undefined) for the given non-function
- // object. Used for support calling objects as functions.
- static Handle<Object> GetFunctionDelegate(Isolate* isolate,
- Handle<Object> object);
- MUST_USE_RESULT static MaybeHandle<Object> TryGetFunctionDelegate(
- Isolate* isolate,
- Handle<Object> object);
+ // Get a function delegate for the given non-function object.
+ // Used for support calling objects as functions.
+ MUST_USE_RESULT static MaybeHandle<JSFunction> GetFunctionDelegate(
+ Isolate* isolate, Handle<Object> object);
// Get a function delegate (or undefined) for the given non-function
// object. Used for support calling objects as constructors.
- static Handle<Object> GetConstructorDelegate(Isolate* isolate,
- Handle<Object> object);
- static MaybeHandle<Object> TryGetConstructorDelegate(Isolate* isolate,
+ MUST_USE_RESULT static MaybeHandle<JSFunction> GetConstructorDelegate(
+ Isolate* isolate, Handle<Object> object);
+
+ private:
+ MUST_USE_RESULT static Handle<String> RenderCallSite(Isolate* isolate,
Michael Starzinger 2015/08/27 10:47:14 nit: If the return value is Handle<> and not Maybe
Handle<Object> object);
};
« no previous file with comments | « src/collection.js ('k') | src/execution.cc » ('j') | src/hydrogen-instructions.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698