src/weak-collection.js - Issue 1316933002: [es6] Initial steps towards a correct implementation of IsCallable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/weak-collection.js

Issue 1316933002: [es6] Initial steps towards a correct implementation of IsCallable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase again. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/weak-collection.js

diff --git a/src/weak-collection.js b/src/weak-collection.js

index 933d753f3fab74457717952ba91dc36423ba21b4..67deddb95ee57491b585bf8d1f0cebe4be800d3d 100644

--- a/src/weak-collection.js

+++ b/src/weak-collection.js

@@ -25,7 +25,7 @@ function WeakMapConstructor(iterable) {

if (!IS_NULL_OR_UNDEFINED(iterable)) {

var adder = this.set;

- if (!IS_SPEC_FUNCTION(adder)) {

+ if (!IS_CALLABLE(adder)) {

throw MakeTypeError(kPropertyNotFunction, 'set', this);

}

for (var nextItem of iterable) {

@@ -114,7 +114,7 @@ function WeakSetConstructor(iterable) {

if (!IS_NULL_OR_UNDEFINED(iterable)) {

var adder = this.add;

- if (!IS_SPEC_FUNCTION(adder)) {

+ if (!IS_CALLABLE(adder)) {

throw MakeTypeError(kPropertyNotFunction, 'add', this);

}

for (var value of iterable) {

« no previous file with comments | « src/v8natives.js ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »