src/builtins.cc - Issue 1316933002: [es6] Initial steps towards a correct implementation of IsCallable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins.cc

Issue 1316933002: [es6] Initial steps towards a correct implementation of IsCallable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase again. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/builtins.cc

diff --git a/src/builtins.cc b/src/builtins.cc

index 461ba84d7c8ef89d0dd5a9f49a49d8705904112c..f06487ddfc695acc3a44fa7ababc945feaae2616 100644

--- a/src/builtins.cc

+++ b/src/builtins.cc

@@ -906,7 +906,7 @@ MUST_USE_RESULT static Object* HandleApiCallAsFunctionOrConstructor(

// Get the invocation callback from the function descriptor that was

// used to create the called object.

- DCHECK(obj->map()->has_instance_call_handler());

+ DCHECK(obj->map()->is_callable());

JSFunction* constructor = JSFunction::cast(obj->map()->GetConstructor());

// TODO(ishell): turn this back to a DCHECK.

CHECK(constructor->shared()->IsApiFunction());

« no previous file with comments | « src/bootstrapper.cc ('k') | src/code-stubs-hydrogen.cc » ('j') | no next file with comments »