Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: src/api-natives.cc

Issue 1316933002: [es6] Initial steps towards a correct implementation of IsCallable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase again. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/api.cc ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/api-natives.h" 5 #include "src/api-natives.h"
6 6
7 #include "src/api.h" 7 #include "src/api.h"
8 #include "src/isolate-inl.h" 8 #include "src/isolate-inl.h"
9 #include "src/lookup.h" 9 #include "src/lookup.h"
10 #include "src/messages.h" 10 #include "src/messages.h"
(...skipping 473 matching lines...) Expand 10 before | Expand all | Expand 10 after
484 } 484 }
485 485
486 // Set interceptor information in the map. 486 // Set interceptor information in the map.
487 if (!obj->named_property_handler()->IsUndefined()) { 487 if (!obj->named_property_handler()->IsUndefined()) {
488 map->set_has_named_interceptor(); 488 map->set_has_named_interceptor();
489 } 489 }
490 if (!obj->indexed_property_handler()->IsUndefined()) { 490 if (!obj->indexed_property_handler()->IsUndefined()) {
491 map->set_has_indexed_interceptor(); 491 map->set_has_indexed_interceptor();
492 } 492 }
493 493
494 // Set instance call-as-function information in the map. 494 // Mark instance as callable in the map.
495 if (!obj->instance_call_handler()->IsUndefined()) { 495 if (!obj->instance_call_handler()->IsUndefined()) {
496 map->set_has_instance_call_handler(); 496 map->set_is_callable();
497 } 497 }
498 498
499 // Recursively copy parent instance templates' accessors, 499 // Recursively copy parent instance templates' accessors,
500 // 'data' may be modified. 500 // 'data' may be modified.
501 int max_number_of_additional_properties = 0; 501 int max_number_of_additional_properties = 0;
502 int max_number_of_static_properties = 0; 502 int max_number_of_static_properties = 0;
503 FunctionTemplateInfo* info = *obj; 503 FunctionTemplateInfo* info = *obj;
504 while (true) { 504 while (true) {
505 if (!info->instance_template()->IsUndefined()) { 505 if (!info->instance_template()->IsUndefined()) {
506 Object* props = ObjectTemplateInfo::cast(info->instance_template()) 506 Object* props = ObjectTemplateInfo::cast(info->instance_template())
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
561 Handle<AccessorInfo> accessor(AccessorInfo::cast(array->get(i))); 561 Handle<AccessorInfo> accessor(AccessorInfo::cast(array->get(i)));
562 JSObject::SetAccessor(result, accessor).Assert(); 562 JSObject::SetAccessor(result, accessor).Assert();
563 } 563 }
564 564
565 DCHECK(result->shared()->IsApiFunction()); 565 DCHECK(result->shared()->IsApiFunction());
566 return result; 566 return result;
567 } 567 }
568 568
569 } // namespace internal 569 } // namespace internal
570 } // namespace v8 570 } // namespace v8
OLDNEW
« no previous file with comments | « src/api.cc ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698