Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 131693002: Remove CppBoundClass and webkit_renderer.gyp (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 11 months ago
Reviewers:
jamesr
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Remove CppBoundClass and webkit_renderer.gyp BUG=297480 R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244491

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1912 lines) Patch
M chrome/chrome_renderer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 6 chunks +0 lines, -7 lines 0 comments Download
D content/renderer/cpp_bound_class_unittest.cc View 1 chunk +0 lines, -241 lines 0 comments Download
D content/test/cpp_binding_example.h View 1 chunk +0 lines, -86 lines 0 comments Download
D content/test/cpp_binding_example.cc View 1 chunk +0 lines, -138 lines 0 comments Download
D webkit/renderer/cpp_bound_class.h View 1 chunk +0 lines, -147 lines 0 comments Download
D webkit/renderer/cpp_bound_class.cc View 1 chunk +0 lines, -329 lines 0 comments Download
D webkit/renderer/cpp_variant.h View 1 chunk +0 lines, -116 lines 0 comments Download
D webkit/renderer/cpp_variant.cc View 1 chunk +0 lines, -268 lines 0 comments Download
D webkit/renderer/cpp_variant_unittest.cc View 1 chunk +0 lines, -514 lines 0 comments Download
D webkit/renderer/webkit_renderer.gyp View 1 chunk +0 lines, -35 lines 0 comments Download
D webkit/renderer/webkit_renderer_export.h View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
plz review (depends on https://codereview.chromium.org/131573003/)
6 years, 11 months ago (2014-01-09 12:54:38 UTC) #1
jamesr
yay! lgtm
6 years, 11 months ago (2014-01-09 21:10:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/131693002/1
6 years, 11 months ago (2014-01-12 09:44:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/131693002/1
6 years, 11 months ago (2014-01-13 12:12:07 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-13 12:12:33 UTC) #5
Message was sent while issue was closed.
Change committed as 244491

Powered by Google App Engine
This is Rietveld 408576698