Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1316883003: Cleanup two trivial PaintOffset bugs in prep for caching paint offset (Closed)

Created:
5 years, 3 months ago by pdr.
Modified:
5 years, 3 months ago
Reviewers:
chrishtr, Xianzhu, trchen
CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Cleanup two trivial PaintOffset bugs in prep for caching paint offset This is a trivial patch, split off from https://codereview.chromium.org/1315993004. This patch removes an incorrect "paintOffset" name and fixes the recorder type in BlockFlowPainter. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201284

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/paint/BlockFlowPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/ImagePainter.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316883003/1
5 years, 3 months ago (2015-08-27 02:18:19 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-27 03:40:25 UTC) #5
pdr.
5 years, 3 months ago (2015-08-27 03:41:06 UTC) #7
chrishtr
lgtm
5 years, 3 months ago (2015-08-27 03:57:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316883003/1
5 years, 3 months ago (2015-08-27 03:58:14 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 04:04:20 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201284

Powered by Google App Engine
This is Rietveld 408576698