Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1316873006: PDF: Strip whitespace when determining whether a PDF's title is empty. (Closed)

Created:
5 years, 3 months ago by Sam McNally
Modified:
5 years, 3 months ago
Reviewers:
raymes
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PDF: Strip whitespace when determining whether a PDF's title is empty. Currently, if a PDF title contains only whitespace, that whitespace-only title is displayed in the UI instead of the last path component. With this change, a title containing only whitespace is ignored just as an empty title is. BUG=527309 Committed: https://crrev.com/8872f4fd0f5075bd7cce282a5f665fdd2efc2116 Cr-Commit-Position: refs/heads/master@{#348061}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M chrome/browser/pdf/pdf_extension_test.cc View 2 chunks +8 lines, -0 lines 0 comments Download
A + chrome/test/data/pdf/test-whitespace-title.pdf View Binary file 0 comments Download
A + chrome/test/data/pdf/whitespace_title_test.js View 1 chunk +2 lines, -2 lines 0 comments Download
M pdf/out_of_process_instance.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Sam McNally
5 years, 3 months ago (2015-09-08 07:32:02 UTC) #3
raymes
lgtm Thanks for this!
5 years, 3 months ago (2015-09-09 04:25:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316873006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316873006/20001
5 years, 3 months ago (2015-09-10 00:02:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 3 months ago (2015-09-10 01:02:33 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8872f4fd0f5075bd7cce282a5f665fdd2efc2116 Cr-Commit-Position: refs/heads/master@{#348061}
5 years, 3 months ago (2015-09-10 01:03:28 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:05:49 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8872f4fd0f5075bd7cce282a5f665fdd2efc2116
Cr-Commit-Position: refs/heads/master@{#348061}

Powered by Google App Engine
This is Rietveld 408576698