chrome/browser/permissions/permission_request_id.h - Issue 1316863010: browser: implement multiple permission requesting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_request_id.h

Issue 1316863010: browser: implement multiple permission requesting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@request-multiple-content

Patch Set: Fix memory leak in permission_manager Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/permissions/permission_manager.cc ('K') | « chrome/browser/permissions/permission_manager.cc ('k') | chrome/browser/permissions/permission_request_id.cc » ('j') | content/browser/permissions/permission_service_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_request_id.h

diff --git a/chrome/browser/permissions/permission_request_id.h b/chrome/browser/permissions/permission_request_id.h

index 25da709342b8853e953dd8ba5a63e51566186c3f..263dc7bd4233bc27a8255c714de304d6e4dc80aa 100644

--- a/chrome/browser/permissions/permission_request_id.h

+++ b/chrome/browser/permissions/permission_request_id.h

@@ -9,6 +9,10 @@

#include "url/gurl.h"

+namespace content {

+class RenderFrameHost;

+} // namespace content

mlamouri (slow - plz ping) 2015/09/23 16:37:37 style: two spaces between '}' and '// namespace co

Lalit Maganti 2015/09/24 09:24:11 Done.

// Uniquely identifies a particular permission request.

// None of the different attributes (render_process_id, render_frame_id or

// request_id) is enough to compare two requests. In order to check if

@@ -16,6 +20,8 @@

// the operator== or operator!=.

class PermissionRequestID {

public:

+ PermissionRequestID(content::RenderFrameHost* render_frame_host,

+ int request_id);

PermissionRequestID(int render_process_id,

int render_frame_id,

int request_id);