Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: chrome/browser/permissions/permission_manager.h

Issue 1316863010: browser: implement multiple permission requesting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@request-multiple-content
Patch Set: Fix memory leak in permission_manager Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_manager.h
diff --git a/chrome/browser/permissions/permission_manager.h b/chrome/browser/permissions/permission_manager.h
index 118bd3f91f67b78d382ede87a215cd3bfc263fef..e5696590e0b8eaf00985d1130e7256c4f09d3e1e 100644
--- a/chrome/browser/permissions/permission_manager.h
+++ b/chrome/browser/permissions/permission_manager.h
@@ -35,7 +35,15 @@ class PermissionManager : public KeyedService,
content::RenderFrameHost* render_frame_host,
const GURL& requesting_origin,
bool user_gesture,
- const base::Callback<void(content::PermissionStatus)>& callback) override;
+ const base::Callback<void(
+ content::PermissionStatus)>& callback) override;
+ int RequestPermissions(
+ const std::vector<content::PermissionType>& permissions,
+ content::RenderFrameHost* render_frame_host,
+ const GURL& requesting_origin,
+ bool user_gesture,
+ const base::Callback<void(
+ const std::vector<content::PermissionStatus>&)>& callback) override;
void CancelPermissionRequest(int request_id) override;
void ResetPermission(content::PermissionType permission,
const GURL& requesting_origin,
@@ -61,10 +69,14 @@ class PermissionManager : public KeyedService,
struct Subscription;
using SubscriptionsMap = IDMap<Subscription, IDMapOwnPointer>;
- void OnPermissionRequestResponse(
+ void OnPermissionsRequestResponse(
int request_id,
- const base::Callback<void(content::PermissionStatus)>& callback,
+ int request_index,
ContentSetting content_setting);
+ void OnPermissionsRequestResponseStatus(
+ int request_id,
+ int request_index,
+ content::PermissionStatus status);
// Not all WebContents are able to display permission requests. If the PBM
// is required but missing for |web_contents|, don't pass along the request.

Powered by Google App Engine
This is Rietveld 408576698