Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: content/public/browser/permission_manager.h

Issue 1316863010: browser: implement multiple permission requesting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@request-multiple-content
Patch Set: Cut down on CL size Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/permission_manager.h
diff --git a/content/public/browser/permission_manager.h b/content/public/browser/permission_manager.h
index 02cd23ba9e781dcf5051677787ca7167f24fcaf7..bdd104b3cc9482cd5268146e0eac077bbb5b4f41 100644
--- a/content/public/browser/permission_manager.h
+++ b/content/public/browser/permission_manager.h
@@ -33,6 +33,20 @@ class CONTENT_EXPORT PermissionManager {
bool user_gesture,
const base::Callback<void(PermissionStatus)>& callback) = 0;
+ // Requests multiple permissions on behalf of a frame identified by
+ // render_frame_host.
+ // When the permission request is handled, whether it failed, timed out or
+ // succeeded, the |callback| will be run.
+ // Returns a request id which can be used to cancel the request (see
+ // CancelPermissionRequest).
mlamouri (slow - plz ping) 2015/09/16 15:08:09 nit: mention the NO_PENDING_REQUEST constant. Als
Lalit Maganti 2015/09/16 17:21:19 Done.
+ virtual int RequestPermissions(
+ const std::vector<PermissionType>& permission,
+ RenderFrameHost* render_frame_host,
+ const GURL& requesting_origin,
+ bool user_gesture,
+ const base::Callback<void(
+ const std::vector<PermissionStatus>&)>& callback) = 0;
mlamouri (slow - plz ping) 2015/09/16 15:08:09 You are still missing the update to aw_permission_
Lalit Maganti 2015/09/16 17:21:18 Good point. Should I implement it properly? If so
+
// Cancels a previous permission request specified by |request_id|.
virtual void CancelPermissionRequest(RenderFrameHost* render_frame_host,
int request_id) = 0;

Powered by Google App Engine
This is Rietveld 408576698