Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: android_webview/browser/aw_permission_manager.cc

Issue 1316863010: browser: implement multiple permission requesting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@request-multiple-content
Patch Set: Fix memory leak in permission_manager Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/browser/aw_permission_manager.h" 5 #include "android_webview/browser/aw_permission_manager.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "android_webview/browser/aw_browser_permission_request_delegate.h" 9 #include "android_webview/browser/aw_browser_permission_request_delegate.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 callback.Run(content::PERMISSION_STATUS_GRANTED); 227 callback.Run(content::PERMISSION_STATUS_GRANTED);
228 break; 228 break;
229 case PermissionType::NUM: 229 case PermissionType::NUM:
230 NOTREACHED() << "PermissionType::NUM was not expected here."; 230 NOTREACHED() << "PermissionType::NUM was not expected here.";
231 callback.Run(content::PERMISSION_STATUS_DENIED); 231 callback.Run(content::PERMISSION_STATUS_DENIED);
232 break; 232 break;
233 } 233 }
234 return request_id; 234 return request_id;
235 } 235 }
236 236
237 int AwPermissionManager::RequestPermissions(
238 const std::vector<PermissionType>& permissions,
239 content::RenderFrameHost* render_frame_host,
240 const GURL& requesting_origin,
241 bool user_gesture,
242 const base::Callback<void(
243 const std::vector<PermissionStatus>&)>& callback) {
244 return kNoPendingRequestOrSubscription;
mlamouri (slow - plz ping) 2015/09/23 16:37:37 Could you add NOTIMPLEMENTED()?
Lalit Maganti 2015/09/24 09:24:11 Done.
245 }
246
237 // static 247 // static
238 void AwPermissionManager::OnRequestResponse( 248 void AwPermissionManager::OnRequestResponse(
239 const base::WeakPtr<AwPermissionManager>& manager, 249 const base::WeakPtr<AwPermissionManager>& manager,
240 int request_id, 250 int request_id,
241 const base::Callback<void(PermissionStatus)>& callback, 251 const base::Callback<void(PermissionStatus)>& callback,
242 bool allowed) { 252 bool allowed) {
243 PermissionStatus status = allowed ? content::PERMISSION_STATUS_GRANTED 253 PermissionStatus status = allowed ? content::PERMISSION_STATUS_GRANTED
244 : content::PERMISSION_STATUS_DENIED; 254 : content::PERMISSION_STATUS_DENIED;
245 if (manager.get()) { 255 if (manager.get()) {
246 PendingRequest* pending_request = 256 PendingRequest* pending_request =
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
353 const GURL& embedding_origin, 363 const GURL& embedding_origin,
354 const base::Callback<void(PermissionStatus)>& callback) { 364 const base::Callback<void(PermissionStatus)>& callback) {
355 return kNoPendingRequestOrSubscription; 365 return kNoPendingRequestOrSubscription;
356 } 366 }
357 367
358 void AwPermissionManager::UnsubscribePermissionStatusChange( 368 void AwPermissionManager::UnsubscribePermissionStatusChange(
359 int subscription_id) { 369 int subscription_id) {
360 } 370 }
361 371
362 } // namespace android_webview 372 } // namespace android_webview
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698