browser: implement multiple permission requesting

content/public/browser/permission_manager.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_PERMISSION_MANAGER_H_
 #define CONTENT_PUBLIC_BROWSER_PERMISSION_MANAGER_H_
 
 #include "content/common/content_export.h"
 #include "content/public/common/permission_status.mojom.h"
 
@@ skipping 15 matching lines @@
   // succeeded, the |callback| will be run.
   // Returns a request id which can be used to cancel the permission (see
   // CancelPermissionRequest
   virtual int RequestPermission(
       PermissionType permission,
       RenderFrameHost* render_frame_host,
       const GURL& requesting_origin,
       bool user_gesture,
       const base::Callback<void(PermissionStatus)>& callback) = 0;
 
+  // Requests multiple permissions on behalf of a frame identified by
+  // render_frame_host.
+  // When the permission request is handled, whether it failed, timed out or
+  // succeeded, the |callback| will be run.
+  // Returns a request id which can be used to cancel the request (see
+  // CancelPermissionRequest).

[mlamouri (slow - plz ping), 2015/09/16 15:08:09]

nit: mention the NO_PENDING_REQUEST constant.

Also, mention that the vector<PermissionStatus> will be ordered the same way as
the vector<PermissionType>

[Lalit Maganti, 2015/09/16 17:21:19]

Done.

+  virtual int RequestPermissions(
+      const std::vector<PermissionType>& permission,
+      RenderFrameHost* render_frame_host,
+      const GURL& requesting_origin,
+      bool user_gesture,
+      const base::Callback<void(
+          const std::vector<PermissionStatus>&)>& callback) = 0;

[mlamouri (slow - plz ping), 2015/09/16 15:08:09]

You are still missing the update to aw_permission_manager.{h,cc}

[Lalit Maganti, 2015/09/16 17:21:18]

Good point. Should I implement it properly? If so I'll have to understand how
their whole system works.

+
   // Cancels a previous permission request specified by |request_id|.
   virtual void CancelPermissionRequest(RenderFrameHost* render_frame_host,
                                        int request_id) = 0;
 
   // Returns the permission status of a given requesting_origin/embedding_origin
   // tuple. This is not taking a RenderFrameHost because the call might happen
   // outside of a frame context.
   virtual PermissionStatus GetPermissionStatus(
       PermissionType permission,
       const GURL& requesting_origin,
@@ skipping 22 matching lines @@
 
   // Unregisters from permission status change notifications.
   // The |subscription_id| must match the value returned by the
   // SubscribePermissionStatusChange call.
   virtual void UnsubscribePermissionStatusChange(int subscription_id) = 0;
 };
 
 }  // namespace content
 
 #endif // CONTENT_PUBLIC_BROWSER_PERMISSION_MANAGER_H_