Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1316863007: Change GetTotalReceivedBytes() from int64 to int64_t. (Closed)

Created:
5 years, 3 months ago by sclittle
Modified:
5 years, 3 months ago
Reviewers:
mmenke, pfeldman
CC:
chromium-reviews, gavinp+disk_chromium.org, cbentzel+watch_chromium.org, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change GetTotalReceivedBytes() from int64 to int64_t. Changes GetTotalReceivedBytes() from int64 to int64_t, from the URLRequest all the way down to the HttpStreams. BUG=527260 TBR=pfeldman@chromium.org Committed: https://crrev.com/4de1bab9bbd6344709382a368cb452556544095e Cr-Commit-Position: refs/heads/master@{#350239}

Patch Set 1 #

Patch Set 2 : Rebased on master #

Patch Set 3 : Rebased on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -39 lines) Patch
M chrome/browser/devtools/devtools_network_transaction.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_network_transaction.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/http/failing_http_transaction_factory.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_basic_stream.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_basic_stream.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_cache_transaction.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_cache_transaction.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_network_transaction.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_response_body_drainer_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_parser.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_transaction.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_transaction_test_util.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_transaction_test_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/http/proxy_connect_redirect_http_stream.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/http/proxy_connect_redirect_http_stream.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_http_stream.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_http_stream.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_http_stream.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_http_stream.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_http_job_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_job.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_job.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_basic_handshake_stream.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_basic_handshake_stream.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
sclittle
pfeldman: chrome/browser/devtools mmenke: net Thanks in advance!
5 years, 3 months ago (2015-09-02 00:59:33 UTC) #2
mmenke
LGTM!
5 years, 3 months ago (2015-09-02 16:22:07 UTC) #3
sclittle
pfeldman: ping
5 years, 3 months ago (2015-09-22 19:52:03 UTC) #5
mmenke
On 2015/09/22 19:52:03, sclittle wrote: > pfeldman: ping sclittle: This is just a trivial API ...
5 years, 3 months ago (2015-09-22 19:52:48 UTC) #6
mmenke
On 2015/09/22 19:52:48, mmenke wrote: > On 2015/09/22 19:52:03, sclittle wrote: > > pfeldman: ping ...
5 years, 3 months ago (2015-09-22 19:53:46 UTC) #7
sclittle
On 2015/09/22 19:53:46, mmenke wrote: > On 2015/09/22 19:52:48, mmenke wrote: > > On 2015/09/22 ...
5 years, 3 months ago (2015-09-22 19:55:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316863007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316863007/60001
5 years, 3 months ago (2015-09-22 19:57:22 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 3 months ago (2015-09-22 21:34:17 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 21:53:09 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4de1bab9bbd6344709382a368cb452556544095e
Cr-Commit-Position: refs/heads/master@{#350239}

Powered by Google App Engine
This is Rietveld 408576698