Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3321)

Unified Diff: chrome/browser/android/net/external_estimate_provider_android.h

Issue 1316863006: Populate EEP estimate in NQE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use EXPECT_TRUE instead of DCHECK Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/net/external_estimate_provider_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/net/external_estimate_provider_android.h
diff --git a/chrome/browser/android/net/external_estimate_provider_android.h b/chrome/browser/android/net/external_estimate_provider_android.h
index ad787e1680d292d6c97498b87ff7829eb65efa2d..8fe6729e9698241595401bcb51e1877e4fdbdef9 100644
--- a/chrome/browser/android/net/external_estimate_provider_android.h
+++ b/chrome/browser/android/net/external_estimate_provider_android.h
@@ -34,30 +34,23 @@ class ExternalEstimateProviderAndroid
~ExternalEstimateProviderAndroid() override;
- // net::ExternalEstimateProvider implementation.
+ // net::ExternalEstimateProvider implementation:
bool GetRTT(base::TimeDelta* rtt) const override;
-
- // net::ExternalEstimateProvider implementation.
bool GetDownstreamThroughputKbps(
int32_t* downstream_throughput_kbps) const override;
-
- // net::ExternalEstimateProvider implementation.
bool GetUpstreamThroughputKbps(
int32_t* upstream_throughput_kbps) const override;
-
- // net::ExternalEstimateProvider implementation.
bool GetTimeSinceLastUpdate(
base::TimeDelta* time_since_last_update) const override;
+ void SetUpdatedEstimateDelegate(
+ net::ExternalEstimateProvider::UpdatedEstimateDelegate* delegate)
+ override;
+ void Update() const override;
// NetworkChangeNotifier::ConnectionTypeObserver implementation.
void OnConnectionTypeChanged(
net::NetworkChangeNotifier::ConnectionType type) override;
- // net::ExternalEstimateProvider implementation.
- void SetUpdatedEstimateDelegate(
- net::ExternalEstimateProvider::UpdatedEstimateDelegate* delegate)
- override;
-
// Called by Java when the external estimate provider has an updated value.
// This may be called on a thread different from |task_runner_|.
void NotifyExternalEstimateProviderAndroidUpdate(JNIEnv* env, jobject obj);
@@ -68,10 +61,6 @@ class ExternalEstimateProviderAndroid
void NotifyUpdatedEstimateAvailable() const;
private:
- // Places a requests to the provider to update the network quality. Returns
- // true if the request was placed successfully.
- void RequestUpdate() const;
-
// Value returned if valid value is unavailable.
int32_t no_value_ = -1;
« no previous file with comments | « no previous file | chrome/browser/android/net/external_estimate_provider_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698