components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h - Issue 1316863006: Populate EEP estimate in NQE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h

Issue 1316863006: Populate EEP estimate in NQE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed bengr comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/net/external_estimate_provider_android_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc » ('j') | net/base/network_quality_estimator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h

index 9fb003cdb0aa6f63a8521948b8ae80e92325ad9b..5c09f2a478621a0e29f89a4253c058b36fe4092c 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h

@@ -230,7 +230,7 @@ class DataReductionProxyConfig

// Should be called only on main frame loads.

void UpdateLoFiStatusOnMainFrameRequest(

bool user_temporarily_disabled_lofi,

- const net::NetworkQualityEstimator* network_quality_estimator);

+ net::NetworkQualityEstimator* network_quality_estimator);

protected:

// Virtualized for mocking. Records UMA containing the result of requesting

@@ -333,7 +333,7 @@ class DataReductionProxyConfig

// |network_quality_estimator| may be NULL.

// Virtualized for unit testing. Should be called only on main frame loads.

virtual bool IsNetworkQualityProhibitivelySlow(

- const net::NetworkQualityEstimator* network_quality_estimator);

+ net::NetworkQualityEstimator* network_quality_estimator);

// Returns true only if Lo-Fi "q=low" header should be added to the Chrome

// Proxy header based on the value of |lofi_status|.

@@ -341,7 +341,7 @@ class DataReductionProxyConfig

// Records Lo-Fi accuracy metric. Should be called only on main frame loads.

void RecordAutoLoFiAccuracyRate(

- const net::NetworkQualityEstimator* network_quality_estimator) const;

+ net::NetworkQualityEstimator* network_quality_estimator) const;

scoped_ptr<SecureProxyChecker> secure_proxy_checker_;