components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc - Issue 1316863006: Populate EEP estimate in NQE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

Issue 1316863006: Populate EEP estimate in NQE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed asvitkine comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/net/external_estimate_provider_android.h ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h » ('j') | net/base/network_quality_estimator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

index 146af5c18ede27f1acdf2b1450d4c143e75df2cf..ebc97e56a6fc3bc776ebb5c87f26b39ed2378703 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

@@ -391,7 +391,7 @@ bool DataReductionProxyConfig::AreProxiesBypassed(

}

bool DataReductionProxyConfig::IsNetworkQualityProhibitivelySlow(

- const net::NetworkQualityEstimator* network_quality_estimator) {

+ net::NetworkQualityEstimator* network_quality_estimator) {

DCHECK(thread_checker_.CalledOnValidThread());

DCHECK(IsIncludedInLoFiEnabledFieldTrial() ||

IsIncludedInLoFiControlFieldTrial() ||

@@ -767,7 +767,7 @@ void DataReductionProxyConfig::SetLoFiModeOff() {

}

void DataReductionProxyConfig::RecordAutoLoFiAccuracyRate(

- const net::NetworkQualityEstimator* network_quality_estimator) const {

+ net::NetworkQualityEstimator* network_quality_estimator) const {

DCHECK(thread_checker_.CalledOnValidThread());

DCHECK(network_quality_estimator);

DCHECK(IsIncludedInLoFiEnabledFieldTrial());

@@ -865,7 +865,7 @@ void DataReductionProxyConfig::RecordAutoLoFiAccuracyRate(

void DataReductionProxyConfig::UpdateLoFiStatusOnMainFrameRequest(

bool user_temporarily_disabled_lofi,

- const net::NetworkQualityEstimator* network_quality_estimator) {

+ net::NetworkQualityEstimator* network_quality_estimator) {

DCHECK(thread_checker_.CalledOnValidThread());

// Record Lo-Fi accuracy rate only if the session is Lo-Fi enabled