Populate EEP estimate in NQE

chrome/browser/android/net/external_estimate_provider_android.h

Index: chrome/browser/android/net/external_estimate_provider_android.h
diff --git a/chrome/browser/android/net/external_estimate_provider_android.h b/chrome/browser/android/net/external_estimate_provider_android.h
index ad787e1680d292d6c97498b87ff7829eb65efa2d..b86560a4ca1f3005ed93ecded60415e9493942de 100644
--- a/chrome/browser/android/net/external_estimate_provider_android.h
+++ b/chrome/browser/android/net/external_estimate_provider_android.h
@@ -34,30 +34,23 @@ class ExternalEstimateProviderAndroid
 
   ~ExternalEstimateProviderAndroid() override;
 
-  // net::ExternalEstimateProvider implementation.
+  // net::ExternalEstimateProvider implementation:
   bool GetRTT(base::TimeDelta* rtt) const override;
-
-  // net::ExternalEstimateProvider implementation.
   bool GetDownstreamThroughputKbps(
       int32_t* downstream_throughput_kbps) const override;
-
-  // net::ExternalEstimateProvider implementation.
   bool GetUpstreamThroughputKbps(
       int32_t* upstream_throughput_kbps) const override;
-
-  // net::ExternalEstimateProvider implementation.
   bool GetTimeSinceLastUpdate(
       base::TimeDelta* time_since_last_update) const override;
+  void SetUpdatedEstimateDelegate(
+      net::ExternalEstimateProvider::UpdatedEstimateDelegate* delegate)
+      override;
+  void RequestUpdate() const override;

[mmenke, 2015/09/11 14:28:08]

I don't see implementations of these in this CL.  Are you missing a file in this
CL?

[tbansal1, 2015/09/11 21:24:30]

These have just been rearranged to keep all overriding functions
together. The implementation is in .cc file. Now, rearranged the contents in the
.cc to match the order in .h.

 
   // NetworkChangeNotifier::ConnectionTypeObserver implementation.
   void OnConnectionTypeChanged(
       net::NetworkChangeNotifier::ConnectionType type) override;
 
-  // net::ExternalEstimateProvider implementation.
-  void SetUpdatedEstimateDelegate(
-      net::ExternalEstimateProvider::UpdatedEstimateDelegate* delegate)
-      override;
-
   // Called by Java when the external estimate provider has an updated value.
   // This may be called on a thread different from |task_runner_|.
   void NotifyExternalEstimateProviderAndroidUpdate(JNIEnv* env, jobject obj);
@@ -68,10 +61,6 @@ class ExternalEstimateProviderAndroid
   void NotifyUpdatedEstimateAvailable() const;
 
  private:
-  // Places a requests to the provider to update the network quality. Returns
-  // true if the request was placed successfully.
-  void RequestUpdate() const;
-
   // Value returned if valid value is unavailable.
   int32_t no_value_ = -1;