Populate EEP estimate in NQE

chrome/browser/android/net/external_estimate_provider_android.h

Index: chrome/browser/android/net/external_estimate_provider_android.h
diff --git a/chrome/browser/android/net/external_estimate_provider_android.h b/chrome/browser/android/net/external_estimate_provider_android.h
index ad787e1680d292d6c97498b87ff7829eb65efa2d..fe96f0d36e06d30ad8725ee85ec9a3d49c4a467c 100644
--- a/chrome/browser/android/net/external_estimate_provider_android.h
+++ b/chrome/browser/android/net/external_estimate_provider_android.h
@@ -34,18 +34,18 @@ class ExternalEstimateProviderAndroid
 
   ~ExternalEstimateProviderAndroid() override;
 
-  // net::ExternalEstimateProvider implementation.
+  // net::ExternalEstimateProvider implementation:
   bool GetRTT(base::TimeDelta* rtt) const override;
 
-  // net::ExternalEstimateProvider implementation.
+  // net::ExternalEstimateProvider implementation:
   bool GetDownstreamThroughputKbps(
       int32_t* downstream_throughput_kbps) const override;
 
-  // net::ExternalEstimateProvider implementation.
+  // net::ExternalEstimateProvider implementation:
   bool GetUpstreamThroughputKbps(
       int32_t* upstream_throughput_kbps) const override;
 
-  // net::ExternalEstimateProvider implementation.
+  // net::ExternalEstimateProvider implementation:
   bool GetTimeSinceLastUpdate(
       base::TimeDelta* time_since_last_update) const override;
 
@@ -53,7 +53,7 @@ class ExternalEstimateProviderAndroid
   void OnConnectionTypeChanged(
       net::NetworkChangeNotifier::ConnectionType type) override;
 
-  // net::ExternalEstimateProvider implementation.
+  // net::ExternalEstimateProvider implementation:

[bengr, 2015/09/08 18:14:23]

I'm ok with you adding this comment only to the first override. Your call.

[tbansal1, 2015/09/08 21:25:55]

Thanks, this made it much cleaner. Done.

   void SetUpdatedEstimateDelegate(
       net::ExternalEstimateProvider::UpdatedEstimateDelegate* delegate)
       override;
@@ -62,16 +62,15 @@ class ExternalEstimateProviderAndroid
   // This may be called on a thread different from |task_runner_|.
   void NotifyExternalEstimateProviderAndroidUpdate(JNIEnv* env, jobject obj);
 
+  // net::ExternalEstimateProvider implementation:
+  void RequestUpdate() const override;

[bengr, 2015/09/08 18:14:23]

I would move this up with the other overrides.

[tbansal1, 2015/09/08 21:25:55]

Done.

+
  protected:
   // Notifies the delegate that a new update to external estimate is available.
   // Protected for testing.
   void NotifyUpdatedEstimateAvailable() const;
 
  private:
-  // Places a requests to the provider to update the network quality. Returns
-  // true if the request was placed successfully.
-  void RequestUpdate() const;
-
   // Value returned if valid value is unavailable.
   int32_t no_value_ = -1;