Populate EEP estimate in NQE

chrome/browser/android/net/external_estimate_provider_android.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_NET_EXTERNAL_ESTIMATE_PROVIDER_ANDROID_H_
 #define CHROME_BROWSER_ANDROID_NET_EXTERNAL_ESTIMATE_PROVIDER_ANDROID_H_
 
 #include <jni.h>
 #include <stdint.h>
 
@@ skipping 16 matching lines @@
 // network change event.
 class ExternalEstimateProviderAndroid
     : public net::NetworkChangeNotifier::ConnectionTypeObserver,
       public net::ExternalEstimateProvider {
  public:
   // Constructs and initializes the underlying provider.
   ExternalEstimateProviderAndroid();
 
   ~ExternalEstimateProviderAndroid() override;
 
-  // net::ExternalEstimateProvider implementation.
+  // net::ExternalEstimateProvider implementation:
   bool GetRTT(base::TimeDelta* rtt) const override;
 
-  // net::ExternalEstimateProvider implementation.
+  // net::ExternalEstimateProvider implementation:
   bool GetDownstreamThroughputKbps(
       int32_t* downstream_throughput_kbps) const override;
 
-  // net::ExternalEstimateProvider implementation.
+  // net::ExternalEstimateProvider implementation:
   bool GetUpstreamThroughputKbps(
       int32_t* upstream_throughput_kbps) const override;
 
-  // net::ExternalEstimateProvider implementation.
+  // net::ExternalEstimateProvider implementation:
   bool GetTimeSinceLastUpdate(
       base::TimeDelta* time_since_last_update) const override;
 
   // NetworkChangeNotifier::ConnectionTypeObserver implementation.
   void OnConnectionTypeChanged(
       net::NetworkChangeNotifier::ConnectionType type) override;
 
-  // net::ExternalEstimateProvider implementation.
+  // net::ExternalEstimateProvider implementation:

[bengr, 2015/09/08 18:14:23]

I'm ok with you adding this comment only to the first override. Your call.

[tbansal1, 2015/09/08 21:25:55]

Thanks, this made it much cleaner. Done.

   void SetUpdatedEstimateDelegate(
       net::ExternalEstimateProvider::UpdatedEstimateDelegate* delegate)
       override;
 
   // Called by Java when the external estimate provider has an updated value.
   // This may be called on a thread different from |task_runner_|.
   void NotifyExternalEstimateProviderAndroidUpdate(JNIEnv* env, jobject obj);
 
+  // net::ExternalEstimateProvider implementation:
+  void RequestUpdate() const override;

[bengr, 2015/09/08 18:14:23]

I would move this up with the other overrides.

[tbansal1, 2015/09/08 21:25:55]

Done.

+
  protected:
   // Notifies the delegate that a new update to external estimate is available.
   // Protected for testing.
   void NotifyUpdatedEstimateAvailable() const;
 
  private:
-  // Places a requests to the provider to update the network quality. Returns
-  // true if the request was placed successfully.
-  void RequestUpdate() const;
-
   // Value returned if valid value is unavailable.
   int32_t no_value_ = -1;
 
   base::android::ScopedJavaGlobalRef<jobject> j_external_estimate_provider_;
 
   // Task runner that accesses ExternalEstimateProviderAndroid members.
   scoped_refptr<base::TaskRunner> task_runner_;
 
   // Notified every time there is an update available from the network quality
   // provider.
   // TODO(tbansal): Add the function that is called by Java side when an update
   // is available.
   net::ExternalEstimateProvider::UpdatedEstimateDelegate* delegate_;
 
   base::ThreadChecker thread_checker_;
 
   // Used for posting tasks.
   base::WeakPtrFactory<ExternalEstimateProviderAndroid> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ExternalEstimateProviderAndroid);
 };
 
 bool RegisterExternalEstimateProviderAndroid(JNIEnv* env);
 
 }  // namespace android
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_ANDROID_NET_EXTERNAL_ESTIMATE_PROVIDER_ANDROID_H_